← Back to issue list

Automatically re-stage if dirty.

View original Github issue

Metadata

Project
snapcraft
Number
#443
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #443 in commit 80de92254, adding dirty detection so YAML changes clean and rerun stage and its dependent strip step, advancing LP #1477904.

Resolution: closed resolved

Reason: PR #443 was merged as commit 80de92254. It made stage detect stale YAML state, clean itself, and invalidate the dependent strip step.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently Snapcraft only notices YAML changes for the strip step. For all other steps, if the step has already run it simply says so and bails. This PR makes progress on LP: [#1477904](https://bugs.launchpad.net/snapcraft/+bug/1477904) by changing that for the stage step, where now if one changes the `stage` keyword in the YAML, stage will notice that it's out of date and automatically clean itself (along with the strip step since it depends upon stage) and re-run.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #443 in commit 80de92254, adding dirty detection so YAML changes clean and rerun stage and its dependent strip step, advancing LP #1477904.
stealth/space-bunny-alpha — closed resolved Merged PR #443 (80de9225) added dirty detection so stage and dependent strip steps clean themselves and rerun after YAML changes, advancing LP #1477904.
stealth/space-bunny-alpha — closed resolved Merged #443 (80de92254), adding automatic dirty-stage detection so YAML changes re-run stage and its dependent strip steps; advances LP #1477904.
qwen/qwen3.6-35b-a3b — — Merged PR automatically re-stages and strips Snapcraft steps upon YAML changes, resolving Launchpad bug #1477904. The update modifies six files to detect out-of-date configurations and trigger a clean re-run.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Snapcraft now automatically detects YAML changes to the stage configuration, cleans the stage and dependent strip steps, and re-runs them. Resolves LP #1477904.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#442 (confidence 100%)

    Complementary merged PR 1a6a21831 added dirty handling for the strip step.

  • Related To: snapcraft#448 (confidence 90%)

    Merged as da1411df0 and also advanced LP #1477904 by adding dirty detection for pull.

Related issues

Issue Project State Summary Similarity
#442 Automatically re-strip if dirty. snapcraft merged Merged PR #442 (commit 1a6a21831): Snapcraft now detects YAML `snap` keyword changes and automatically cleans and re-runs the strip step instead of halting, advancing LP #1477904.
75%
#447 Detect dirty build step. snapcraft merged Merged PR #447 (commit 6224553ae): build step now detects YAML changes affecting a part's plugin build attributes and errors asking the user to clean, advancing LP bug #1477904. Unlike strip/stage, build is not auto-cleaned.
75%