← Back to issue list

tests(spread): add remote-build spread test

View original Github issue

Metadata

Project
snapcraft
Number
#4433
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4433 (commit 4a0a91117), adding weekly spread coverage for new and legacy remote-build implementations and resolving #4398.

Resolution: closed resolved

Reason: PR #4433 was merged as commit 4a0a91117, adding remote-build spread tests and closing the directly linked test-coverage issue #4398.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Test the new and legacy remote-build in the weekly spread test. See a successful workflow job [here](https://github.com/snapcore/snapcraft/actions/runs/6711140620/job/18238067023) Fixes #4398 (CRAFT-2095)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4433 (commit 4a0a91117), adding weekly spread coverage for new and legacy remote-build implementations and resolving #4398.
stealth/space-bunny-alpha — closed resolved Merged PR #4433 (commit 4a0a91117) added weekly Spread coverage for new and legacy remote-build flows, fixing #4398.
stealth/space-bunny-alpha — closed resolved Merged PR #4433 (commit 4a0a91117), adding weekly spread tests for new and legacy remote-build and fixing #4398.
qwen/qwen3.6-35b-a3b — — Merged changes adding spread tests for new and legacy remote-build, resolving issue #4398. Approved by two reviewers with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Adds spread tests for new and legacy remote-build, fixing #4398. CI validated the changes despite a minor coverage drop. Maintainer advised force-pushing if store tests fail, but the PR was successfully integrated.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#4398 Add spread test for remote-build snapcraft closed Remote-build Spread coverage was added in commit 4a0a91117, resolving the missing tests for the new builder and legacy fallback.
87%
#4767 tests: fix remote-build tests snapcraft merged Merged #4767 in commit 2b1e68cb5, repairing weekly remote-build tests except Fedora, which lacks compatible Spread test support.
85%
#1600 test(spread): move flaky parallel-build test to weeklies charmcraft merged Merged in commit a1d285c7, moving the flaky parallel-build Spread test from regular CI to weeklies as a workaround for #1332.
79%
#1366 tests(spread): make release test less flaky charmcraft merged Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362.
77%
#2763 fix(tests/spread): fix reactive spread tests charmcraft merged Merged #2763 as 6e775f4a: split reactive spread coverage by legacy/Resolute, enabled binary wheels, and removed obsolete build flags.
76%
#13 test(spread): add more spread tests snapcraft-rocks merged Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files).
75%
#762 tests(spread): add a test for the fetch-service rockcraft merged Merged PR #762 in commit f4cff41c, adding 51 lines of spread-test coverage for the fetch service across two files.
74%
#16 tests: add spread support rockcraft merged Merged PR #16 added Spread support for CRAFT-865 via commit 3aeba2b3 (merge commit 5bf2680a).
74%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
74%
#613 Execute spread testing craft-application closed Spread testing delivered: TestingService and an opt-in 'test' command merged via PR #694 (commit 4910b2d8), building on #565 and #592. Maintainer mr-cal closed the issue citing that PR.
74%