fix(lifecycle): return correct base when using devel for build-base
Metadata
Current evaluation
Merged fix for get_effective_base() returning devel for build-base, preventing invalid LD_LIBRARY_PATH paths. Approved by three reviewers, passed CI, and resolves #4508. Reviewers requested targeting hotfix/8.0 and discussed a core24 validator.
Suggested action: —
No scores available.
Issue body
`get_effective_base()` should not return "devel" and pass it to the `PartsLifecycle()`, which make the parts think the coreXX is "devel". Thus checking the wrong path for dynamic linking.
`LD_LIBRARY_PATH=...:/snap/core24/current/lib:/snap/core24/current/usr/lib:...`
become
`LD_LIBRARY_PATH=...:/snap/devel/current/lib:/snap/devel/current/usr/lib:...`
which not exists.
Fix: #4508
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for get_effective_base() returning devel for build-base, preventing invalid LD_LIBRARY_PATH paths. Approved by three reviewers, passed CI, and resolves #4508. Reviewers requested targeting hotfix/8.0 and discussed a core24 validator. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix correcting get_effective_base() to return the actual base instead of devel as build-base, fixing invalid dynamic linking paths. Resolves #4508. Targeted for hotfix/8.0. Reviewers discussed adding a validator for core24. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix correcting get_effective_base() to return the actual base instead of devel when using build-base, resolving invalid dynamic linking paths. Closes #4508 and targets hotfix/8.0. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4540 fix(lifecycle): return correct base when using devel for build-base (… | snapcraft | merged | Merged a fix to return the correct base when using devel for build-base. Approved by two reviewers, the change spans seven files. Codecov noted one uncovered line, but the pull request was successfully merged. | |
| #1153 fix(project): handle devel bases in is_effective_base_eol() | craft-application | merged | Merged fix for is_effective_base_eol() crash on devel or unrecognized bases. Now treats devel as never EOL and catches unknown errors, matching sibling methods. Includes unit tests and passed review. | |
| #249 fix(test): build on devel, which can be any base | imagecraft | merged | Merged a test fix switching the build target from Ubuntu 24.04 to devel to bypass base version checks. Approved by two reviewers and passed CI checks before merging. |