fix(lifecycle): return correct base when using devel for build-base (…
Metadata
Current evaluation
Merged a fix to return the correct base when using devel for build-base. Approved by two reviewers, the change spans seven files. Codecov noted one uncovered line, but the pull request was successfully merged.
Suggested action: —
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix to return the correct base when using devel for build-base. Approved by two reviewers, the change spans seven files. Codecov noted one uncovered line, but the pull request was successfully merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix correcting the lifecycle base return value when using devel for build-base. The change by syu-w was integrated into the codebase, with Codecov noting a single line of missing coverage that did not block the merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix ensuring the correct base is returned when using devel for build-base. Maintainer syu-w integrated the update. Codecov flagged one line missing coverage, but the changes were accepted and merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4523 fix(lifecycle): return correct base when using devel for build-base | snapcraft | merged | Merged fix for get_effective_base() returning devel for build-base, preventing invalid LD_LIBRARY_PATH paths. Approved by three reviewers, passed CI, and resolves #4508. Reviewers requested targeting hotfix/8.0 and discussed a core24 validator. | |
| #249 fix(test): build on devel, which can be any base | imagecraft | merged | Merged a test fix switching the build target from Ubuntu 24.04 to devel to bypass base version checks. Approved by two reviewers and passed CI checks before merging. | |
| #1153 fix(project): handle devel bases in is_effective_base_eol() | craft-application | merged | Merged fix for is_effective_base_eol() crash on devel or unrecognized bases. Now treats devel as never EOL and catches unknown errors, matching sibling methods. Includes unit tests and passed review. | |
| #263 feat(lifecycle)!: don't build on incompatible bases | craft-application | merged | Merged following reviewer approval and CI passes. Introduces a base compatibility check in the Lifecycle service to block builds on mismatched host OS environments, resolving issue #154. | |
| #414 feat(lifecycle): break out _get_build_for method | craft-application | merged | Merged a refactoring that extracts the _get_build_for method from the lifecycle module, resolving issue #394. Approved by two reviewers and passing CI, the change modifies three files with a net addition of 81 lines. | |
| #4068 meta: allow support for `build-base: devel` | snapcraft | merged | Merged after approval and CI checks. Enables build-base: devel support and sets the grade to devel. A testing issue requiring manual apt update on the lunar image was resolved via a craft-providers update. |