← Back to issue list

fix(tests): upload a larger snap

View original Github issue

Metadata

Project
snapcraft
Number
#4583
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. The change uploads a larger snap to work around a review-tools issue caused by snapd's squashfs block size change. Approved by reviewers, passed CI, and slightly improved test coverage.

Suggested action:

No scores available.

Issue body

This works around the review-tools issue triggered by the squasfs block size change in snapd. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. The change uploads a larger snap to work around a review-tools issue caused by snapd's squashfs block size change. Approved by reviewers, passed CI, and slightly improved test coverage.
qwen3.6-35b-a3b-mtp-q6 Merged a test fix uploading a larger snap to bypass a review-tools issue triggered by a snapd squashfs block size change. Code coverage improved to 88.35% with full test coverage on modified lines.
qwen3.6-35b-a3b-mtp-q6 Merged a workaround for a review-tools issue caused by snapd's squashfs block size change. The change uploads a larger snap, passes all tests, and slightly increases code coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#639 Use a snap that doesn't require a manual review for the upload test snapcraft merged Merged a change replacing a snap requiring manual review with an auto-approved alternative for the upload test, resolving Launchpad bug #1600078. The update modifies two files to streamline the test workflow.
71%
#544 fix(i/snap): don't reject non-snap squashfs files fetch-service merged Merged a fix to the snap inspector that ignores non-snap squashfs files instead of rejecting them. Approved by two reviewers, passed all CI checks, and applied with 16 additions and 4 deletions across two files.
71%
#178 fix(inspectors/snap): minor inspector fixes and more test coverage fetch-service merged Merged minor snap inspector fixes, adding out-of-bounds access guards and error handling for squashfs reader creation. Improved test coverage. Approved by two reviewers and passed CI.
70%