← Back to issue list

feat: use craft-application project variables

View original Github issue

Metadata

Project
snapcraft
Number
#4601
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged after three approvals and passing CI. Implements version and grade as craft-application project variables updatable via craftctl. Rebased and test failures resolved prior to merge.

Suggested action:

No scores available.

Issue body

Define `version` and `grade` as craft-application project variables that can be updated using craftctl. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after three approvals and passing CI. Implements version and grade as craft-application project variables updatable via craftctl. Rebased and test failures resolved prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged feature adding craft-application project variables for version and grade, updatable via craftctl. After rebasing and fixing dependency-related test failures, all checks passed and the changes were integrated.
qwen3.6-35b-a3b-mtp-q6 Merged after resolving CI failures caused by missing craft-app dependencies. Implements version and grade as craft-application project variables updatable via craftctl, with all tests passing and coverage requirements met.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#872 feat: support nested project variables craft-application merged Merged following three approvals and successful CI checks. The update enables nested project variables, altering 22 files (+526/-62 lines). It relies on craft-parts PR #1220 and addresses SNAPCRAFT-1054.
76%
#217 feat: implement adoptable project variables craft-application merged Merged implementation of adoptable project variables, enabling metadata fields to be set via craftctl. Approved by two reviewers, passed CI, and includes integration tests. Changes span 17 files with 216 additions and 24 deletions.
76%
#1399 feat: craft-application rebase charmcraft merged Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests.
75%
#5499 fix: evaluate variables in project file snapcraft merged Merged fix for project variables not evaluating in project files, caused by the craft-application 5 rebase. Includes a core22 spread test and changelog update. Resolves #5491.
73%
#1454 build: update craft-application charmcraft merged Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments.
72%
#5753 feat: adopt component variables snapcraft merged Merged after reviewer approval and passing CI checks. The change adopts component variables, enabling craftctl to set component versions for core22 and core24 snaps. Resolves #5240.
72%
#1330 feat(craft-app): Add craft-application services charmcraft merged Merged feat(craft-app): Add craft-application services. Approved by two reviewers, the change modified 56 files with 2143 additions and 230 deletions. The author fixed changelist misalignments causing spread test failures before merge.
72%
#4614 feat(craft-application): migrate version command snapcraft merged Merged, resolving issue #4468. The version command was migrated to craft-application across seven files. Approved by two reviewers and integrated despite minor Codecov coverage warnings.
71%
#576 feat: extend craft_application.git module craft-application merged Merged after approval from three reviewers and passing CI checks. The update extends the craft_application.git module by adding GitRepo methods for remote URL management, commit verification, fetch operations, and subprocess integration.
71%
#1220 feat: support nested project variables craft-parts merged Merged. Adds nested project variable support via a new ProjectVarInfo class, enabling commands like craftctl set var.subvar=foo. Approved by three reviewers, passed all CI checks, and updated 19 files.
71%