← Back to issue list

feat: adopt component variables

View original Github issue

Metadata

Project
snapcraft
Number
#5753
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Merged PR #5753 (SNAPCRAFT-65, SNAPCRAFT-1056) added component variables so craftctl can set component versions for core22 and core24 snaps, closing #5240. Commits: 6b6f7d9ee, 766562286.

Resolution: closed resolved

Reason: PR #5753 was approved and merged with all CI checks passing, in two commits 6b6f7d9ee (core24) and 766562286 (core22), implementing the component-version adoption requested in issue #5240.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- Allows setting component versions with craftctl for core22 and core24 snaps. For example: I recommend reviewing per-commit. The enabling core24 is straightforward, whereas enabling core22 is a mini copy of https://github.com/canonical/craft-application/pull/872. Blocked by https://github.com/canonical/craft-application/pull/892 Fixes #5240 (SNAPCRAFT-65) (SNAPCRAFT-1056)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5753 (SNAPCRAFT-65, SNAPCRAFT-1056) added component variables so craftctl can set component versions for core22 and core24 snaps, closing #5240. Commits: 6b6f7d9ee, 766562286.
stealth/space-bunny-alpha — closed resolved Merged PR #5753, enabling craftctl to adopt component versions for core22 and core24 snaps and resolving #5240.
qwen/qwen3.6-35b-a3b — — Merged after reviewer approval and passing CI checks. The change adopts component variables, enabling craftctl to set component versions for core22 and core24 snaps. Resolves #5240.
qwen3.6-35b-a3b-mtp-q6 — — Merged following a rebase and update to craft-application 5.9.1. The change adopts component variables, enabling craftctl to set component versions for core22 and core24 snaps, resolving issue #5240.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5240 (confidence 95%)

    PR states 'Fixes #5240' (adopt-info analogue for components); that issue is now closed by this merge.

  • Likely Fixed By: canonical/craft-application#892 (confidence 80%)

    PR body lists it as blocking; that upstream fix (don't cache the project) was merged with downstream testing done in #5753.

  • Related To: canonical/craft-application#872 (confidence 60%)

    Referenced by the author as the model for the core22 portion of the change.

Related issues

Issue Project State Summary Similarity
#5240 Add `adopt-info` analogue for components snapcraft closed Implemented component version adoption via merged PR #5753 (commits 6b6f7d9ee, 766562286), allowing craftctl to set component versions in Snapcraft 8.13.
75%
#5757 docs: add docs for setting component versions snapcraft merged Merged PR #5757 as commit ffb793a0e, adding a Snapcraft 8.13 component-version release note and linking the component guide to the craftctl how-to.
72%
#2122 many: introduce variables for part src and build snapcraft merged Merged in commit 31307b5de via #2122, adding source/build directory variables and centralizing SNAPCRAFT_* environment handling; resolved LP #1763028.
72%
#2080695 `adopt-info:` for components snapcraft (launchpad) closed Feature request for adopting component versions via adopt-info was implemented in canonical/snapcraft PR #5753 (commits 6b6f7d9ee, 766562286), letting craftctl set component metadata. ClOSED as completed by ~mr-cal.
72%
#3748 parts: define variables and expand them in snapcraft.yaml snapcraft merged Merged PR #3748 in commit fba20a970, adding global and step-specific SNAPCRAFT_* variables for snapcraft.yaml expansion and lifecycle environments.
71%
#5727 docs: document custom project vars (SNAPCRAFT-1053) snapcraft merged Merged in canonical/snapcraft#5727 as cba259a0d, documenting custom project variables for SNAPCRAFT-1053 after the work moved from canonical/craft-parts#1216.
71%
#4601 feat: use craft-application project variables snapcraft merged Merged as b6832072, defining version and grade as craft-application project variables that craftctl can update.
70%
#3677 parts: add craftctl support snapcraft merged Merged #3677 added craftctl support, project-variable assignment, and adopt-info configuration in commit 293ac060b.
70%