← Back to issue list

feat: adopt component variables

View original Github issue

Metadata

Project
snapcraft
Number
#5753
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Merged after reviewer approval and passing CI checks. The change adopts component variables, enabling craftctl to set component versions for core22 and core24 snaps. Resolves #5240.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- Allows setting component versions with craftctl for core22 and core24 snaps. For example: I recommend reviewing per-commit. The enabling core24 is straightforward, whereas enabling core22 is a mini copy of https://github.com/canonical/craft-application/pull/872. Blocked by https://github.com/canonical/craft-application/pull/892 Fixes #5240 (SNAPCRAFT-65) (SNAPCRAFT-1056)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after reviewer approval and passing CI checks. The change adopts component variables, enabling craftctl to set component versions for core22 and core24 snaps. Resolves #5240.
qwen3.6-35b-a3b-mtp-q6 Merged following a rebase and update to craft-application 5.9.1. The change adopts component variables, enabling craftctl to set component versions for core22 and core24 snaps, resolving issue #5240.
qwen3.6-35b-a3b-mtp-q6 Merged to enable setting component versions via craftctl for core22 and core24 snaps. The update bumps the craft-application dependency to 5.9.1 and resolves issue #5240.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#217 feat: implement adoptable project variables craft-application merged Merged implementation of adoptable project variables, enabling metadata fields to be set via craftctl. Approved by two reviewers, passed CI, and includes integration tests. Changes span 17 files with 216 additions and 24 deletions.
77%
#872 feat: support nested project variables craft-application merged Merged following three approvals and successful CI checks. The update enables nested project variables, altering 22 files (+526/-62 lines). It relies on craft-parts PR #1220 and addresses SNAPCRAFT-1054.
73%
#4601 feat: use craft-application project variables snapcraft merged Merged after three approvals and passing CI. Implements version and grade as craft-application project variables updatable via craftctl. Rebased and test failures resolved prior to merge.
72%
#190 craftctl: set variables from parts adopting metadata craft-parts merged Merged. Restricts craftctl variable assignment to the specified part during lifecycle creation, removing the need for an adopting part when project variables are undeclared. Approved, passed CI, and integrated. Author notes future refactoring for validation and scope adjustments.
70%
#4722 feat: package component hooks for core22 snapcraft merged Merged to enable packaging of component hooks for core22. Implementation was completed in #4717; this change activates the feature. Approved by two reviewers, passed CI, and modified four files.
70%