← Back to issue list

feat: core24 using Craft Application and core22 components

View original Github issue

Metadata

Project
snapcraft
Number
#4693
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI. Updated core24 to use Craft Application and core22 components across 284 files, adding over 10,000 lines and removing nearly 2,000. Codecov noted minor coverage gaps, but changes were integrated.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI. Updated core24 to use Craft Application and core22 components across 284 files, adding over 10,000 lines and removing nearly 2,000. Codecov noted minor coverage gaps, but changes were integrated.
qwen3.6-35b-a3b-mtp-q6 Merged the core24 update to utilize Craft Application and core22 components. The change passed automated code coverage checks at 95.97% patch coverage and was successfully integrated into the repository by maintainer sergiusens.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer sergiusens, this update enables core24 to use the Craft Application and core22 components. Codecov reported 95.98% patch coverage with minor missing lines, and the feature was successfully integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4692 feat: core24 using Craft Application and core22 components snapcraft closed Superseded by PR #4693 due to branch protection rules. Changes adding core24 support with Craft Application and core22 components were closed without review or merge.
86%
#4717 feat: package component hooks for core24 snapcraft merged Merged following two approvals and passing CI checks. The update adds support for packaging component hooks for core24, modifying 15 files with 419 additions and 89 deletions. Test coverage requirements were met.
79%
#4565 feat: implement core24 "pack" command snapcraft merged Merged the core24 pack and clean command implementation. Maintainer rebase-merged after two approvals, resolving #4470. Known test failures from missing dependencies were intentionally accepted to advance the craft-application branch.
76%
#4557 feat!: fail if we know the project is core24 snapcraft merged Merged a breaking change that fails early for core24 projects. Added core24 spread tests with expected failures and updated CI workflows. Approved by two reviewers and passed all checks.
74%
#1399 feat: craft-application rebase charmcraft merged Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests.
72%
#4630 feat: add platforms and drop architectures for core24 snapcraft merged Merged platforms keyword addition and architectures removal for core24. Build-for propagation and validation test failures were resolved. Remaining clean command edge cases were deferred to an upstream craft-application issue.
72%
#4873 feat: support "build-for: [all]" in core24 snapcraft merged Merged implementation of build-for: [all] support for core24 snaps, fixing #4854. Changes were squashed, craft-application updated to 3.0.0, and unit and spread tests added after two approvals.
72%
#4700 feat: partitions for core24 snapcraft merged Merged feature adding partitions for core24. Approved by two reviewers, the PR modifies 16 files (+461/-26 lines). Codecov flagged 10 lines missing coverage, but the changes were successfully integrated into main.
72%
#4633 chore: merge main into feature/craft-application snapcraft merged Merged into feature/craft-application after three approvals and passing CI. Updated 23 files with full test coverage on changed lines, maintaining 89.14% project coverage.
71%
#4606 feat(app): support extensions in core24 snapcraft merged Added extension support to core24. Merged after approval by two reviewers, passing all CI checks with 100% coverage on modified lines. The change updated nine files, adding 183 lines and removing 30.
71%