← Back to issue list

feat: package component hooks for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4717
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4717 as commit aafbe672b, adding core24 component-hook packaging and test coverage for CRAFT-2540.

Resolution: closed resolved

Reason: PR #4717 was approved and merged into main as commit aafbe672b. It implemented packaging support for component hooks targeting core24.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Add support for packaging component hooks for core24. I recommend reviewing per-commit. (CRAFT-2540)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4717 as commit aafbe672b, adding core24 component-hook packaging and test coverage for CRAFT-2540.
stealth/space-bunny-alpha — closed resolved Merged PR #4717 as commit aafbe672b, adding core24 component-hook packaging and comprehensive tests.
stealth/space-bunny-alpha — closed resolved Merged #4717 as aafbe672b, adding support for packaging component hooks for core24 (CRAFT-2540).
qwen/qwen3.6-35b-a3b — — Merged following two approvals and passing CI checks. The update adds support for packaging component hooks for core24, modifying 15 files with 419 additions and 89 deletions. Test coverage requirements were met.
qwen3.6-35b-a3b-mtp-q6 — — Merged after passing linting and tests with full coverage on modified lines. Adds support for packaging component hooks for core24. Resolves CRAFT-2540.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#4570 (confidence 98%)

    The broader component-hooks support issue was resolved through PRs #4703, #4717, and #4722.

  • Related To: canonical/snapcraft#4703 (confidence 92%)

    Added the component metadata for hooks used by this implementation.

  • Related To: canonical/snapcraft#4722 (confidence 92%)

    Added the corresponding component-hook packaging support for core22.

Related issues

Issue Project State Summary Similarity
#4722 feat: package component hooks for core22 snapcraft merged Merged PR #4722 as commit 9a5dbfa69, enabling component-hook packaging for core22 with the implementation from #4717.
87%
#4703 feat: add component metadata for hooks snapcraft merged Merged PR #4703 (commit aa49b3b72, CRAFT-2463) adding component hook metadata: project definition plus output into the component's meta/component.yaml. Built on merged #4701; follow-ups #4717/#4722 added core24/core22 component hook packaging, closing #4570.
80%
#4570 Support component hooks snapcraft closed Component hooks were implemented by merged PRs #4703, #4717 and #4722, adding hook metadata and core24/core22 packaging support.
77%
#4565 feat: implement core24 "pack" command snapcraft merged Rebase-merged PR #4565 (commit e75d0e93b) on feature/craft-application: implemented the core24 "pack" command (Package service) plus "clean", re-enabled their spread tests and updated expected errors. Closes #4470.
77%
#4592 Support project hooks for core24 snaps snapcraft closed Core24 project hook packaging was implemented in snapcraft#4717 and merged as commit aafbe672b, with hook-packaging tests.
75%
#4692 feat: core24 using Craft Application and core22 components snapcraft closed Closed unmerged and superseded by canonical/snapcraft#4693 (merge commit ab1c86df3), which landed the same core24 Craft Application / core22 components work; branch was protected.
73%
#4862 tests: add a test for package filtering in core24 snapcraft merged Merged PR #4862 (commit 2d16cd861) added core24 package-filtering test coverage and closed #4865 after a craft-parts bump and update onto hotfix/8.2.
70%