← Back to issue list

feat: partitions for core24

View original Github issue

Metadata

Project
snapcraft
Number
#4700
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged feature adding partitions for core24. Approved by two reviewers, the PR modifies 16 files (+461/-26 lines). Codecov flagged 10 lines missing coverage, but the changes were successfully integrated into main.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged feature adding partitions for core24. Approved by two reviewers, the PR modifies 16 files (+461/-26 lines). Codecov flagged 10 lines missing coverage, but the changes were successfully integrated into main.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Adds partition support for core24. The change passed review and was integrated despite a Codecov notice regarding minor patch coverage gaps.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer sergiusens. Introduces partition support for core24. Despite Codecov reporting 79.17% patch coverage with 10 missing lines, the changes passed review and were integrated into main.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4639 feat: enable patchelf for core24 snapcraft merged Enabled patchelf for core24. Merged after approval from two reviewers and passing CI checks. The change updates six files (+75/-9 lines) with full test coverage on modified code.
76%
#4557 feat!: fail if we know the project is core24 snapcraft merged Merged a breaking change that fails early for core24 projects. Added core24 spread tests with expected failures and updated CI workflows. Approved by two reviewers and passed all checks.
72%
#5209 tests: enable core24 plugin tests snapcraft merged Merged after four reviewers approved. The changes enable core24 plugin tests across 132 files, adding 2,795 lines. CI checks passed and the code was successfully integrated into the main branch.
72%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged following two reviewer approvals and passing CI. Updates utility functions to handle namespaced partitions across eight files (+229/-72 lines). Resolves #596 and CRAFT-2303.
72%
#4693 feat: core24 using Craft Application and core22 components snapcraft merged Merged after two approvals and passing CI. Updated core24 to use Craft Application and core22 components across 284 files, adding over 10,000 lines and removing nearly 2,000. Codecov noted minor coverage gaps, but changes were integrated.
72%
#6397 feat: partitions always enabled snapcraft open Small change to always enable partitions unconditionally. No reviews, no comments, 16 days old, CI passing.
71%
#1035 feat: reconcile overlays and partition features craft-parts merged Merged. Implements simultaneous overlay and partition feature support, resolving issue #1028. Approved by three reviewers with passing CI. Further tests and refactoring will follow in a subsequent PR.
71%
#30 feat: merge 'bundle-snap' into 'core24-8' snapcraft-rocks merged Merged 'bundle-snap' into 'core24-8' following dual reviewer approval. The branch integrates PR #28 and applies a core24 codebase upgrade, adding 113 lines across seven files.
71%
#4690 feat(extensions): support core24 in the gnome extensions snapcraft merged Merged to add core24 support to GNOME extensions. Approved by four reviewers, passed all CI checks, and maintained 100% test coverage on modified lines across five files.
70%
#1699 feat: partitions always enabled craft-parts open Consolidates enabled/disabled partition code paths into a unified approach where no partitions defaults to a single partition. CI passing, awaiting review.
70%