← Back to issue list

feat: cleaning with partitions

View original Github issue

Metadata

Project
craft-parts
Number
#1110
Type
pull request
State
merged
Author
upils
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1110 adds partition-aware cleanup of shared areas for CRAFT-4585, following prerequisite #1109; it is recorded on main as commit 0584c19c.

Resolution: closed resolved

Reason: PR #1110 was merged after #1109 and appears on main as commit 0584c19c. The change fixes the shared-directory cleanup problem tracked in #665 when partitions are enabled.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ----- Properly clean shared area taking into account the partitions. To be merged **after** https://github.com/canonical/craft-parts/pull/1109 CRAFT-4585

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1110 adds partition-aware cleanup of shared areas for CRAFT-4585, following prerequisite #1109; it is recorded on main as commit 0584c19c.
stealth/space-bunny-alpha — closed resolved Merged PR #1110, updating shared-area cleaning to account for partitions and adding a changelog entry; commit ef08f6f0c8bcb01c782c44d8018bcdee4d391963.
qwen/qwen3.6-35b-a3b — — Merged after craft-parts PR #1109. Properly cleans the shared area while accounting for partitions, resolving issue #665. Includes a changelog entry and passed three reviews.
qwen3.6-35b-a3b-mtp-q6 — — Merged after craft-parts#1109. Properly cleans the shared area while accounting for partitions, resolving issue #665. Includes a changelog entry for the fix.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#665 (confidence 100%)

    Direct bug report for shared directories not being cleaned correctly with partitions.

  • Related To: canonical/craft-parts#1109 (confidence 100%)

    Explicit prerequisite that added tracking for content migrated to partitions.

Related issues

Issue Project State Summary Similarity
#652 feat(partitions): clean partition directories craft-parts merged Merged #652 via commit 797109e8, adding partition-directory cleanup when partitions are enabled and fixing #634 (CRAFT-2417).
79%
#1035 feat: reconcile overlays and partition features craft-parts merged Merged PR #1035 at commit b575539e, enabling overlay and partition features simultaneously and fixing canonical/craft-parts#1028.
76%
#763 partitions feature documentation craft-parts merged Merged developer-facing partitions documentation in commit cdcc9dbc, completing CRAFT-3030 after approval by two reviewers.
75%
#88 feat: create craft partitions from structure items imagecraft merged Merged as commit 96b8742, adding dynamic craft-partition creation from structure items in the Volumes section and resolving imagecraft#81.
74%
#600 feat(partitions): handle namespaced partitions in utils craft-parts merged Merged into main in commit f387afa5 (PR #600), adding namespaced-partition handling to four partition utilities and resolving craft-parts#596.
73%
#634 Clean partitions directories craft-parts closed Partition directories are now removed during part cleaning when partitions are enabled. Fixed by merged PR canonical/craft-parts#652 in commit 797109e8.
72%
#800 feat: allow hyphens in partition names craft-parts merged Merged PR #800 as commit 184d5142, adding support for hyphens in partition names for CRAFT-3031.
72%
#6397 feat: partitions always enabled snapcraft open Turns on craft-parts partitions consistently in snapcraft (4 files, +8/-9) as a manual-spread follow-up to craft-parts#1699. Awaiting review: lint/files failing, 3 checks pending, one unresolved comment, upstream craft-parts PR still open.
72%
#497 partitions: add utility to make partition compatible filepaths craft-parts merged Merged #497, adding a utility that converts filepaths into partition-compatible paths for CRAFT-1845; landed as commit 20e994f8.
72%
#602 feat(partitions): create envvars for namespaced partitions craft-parts merged Merged PR #602 (commit a8615eec) adds CRAFT_<PARTITION>_STAGE/PRIME env vars for namespaced partitions, drops #600's xfails, and fixes #597.
72%