refactor: migrate core22 store commands
Metadata
Current evaluation
Merged a refactor migrating core22 store commands to craft_application.AppCommand. This enables store operations for core24 snaps and fixes a bug where project-agnostic commands like snapcraft login failed in core24 directories.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Migrate core22 commands related to the store from `craft_cli.BaseCommand` to `craft_application.commands.AppCommand`.
This allows store operations for core24 snaps. It also fixes a behavior where commands unrelated to a project would fail. For example, running `snapcraft login` in a core24 project directory would fail with `'login' is not implemented in core24!`
Pycharm's refactor utility did not help but it was straightforward enough to do manually.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor migrating core22 store commands to craft_application.AppCommand. This enables store operations for core24 snaps and fixes a bug where project-agnostic commands like snapcraft login failed in core24 directories. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged migration of core22 store commands to craft_application.commands.AppCommand. Fixes command failures in core24 directories and enables core24 store operations. Passed tests and coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring of core22 store commands to craft_application.commands.AppCommand. Enables core24 store operations and fixes command failures in core24 project directories. All changes passed test coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4830 refactor: migrate commands to craft-application | snapcraft | merged | Merged following three approvals and passing CI. Migrates remaining commands to core24/craft-application, updating snapcraft init to generate core24 files, correcting list-plugins output, and refreshing command docs. Resolves #4742. | |
| #1358 feat(craft-application): migrate store commands | charmcraft | merged | Migrated store commands in craft-application. Approved by three reviewers and merged, modifying 29 files with 2859 additions and 344 deletions. | |
| #5136 chore: migrate snapcraft itself to core24 | snapcraft | merged | Migrating snapcraft to core24 was approved by two reviewers, passed CI checks, and successfully merged. The update modified 9 files to align the project with the core24 base. |