refactor: update grammar models
Metadata
Current evaluation
Superseded by the merged Pydantic 2 refactor in #4955, which completed the intended grammar-model modernization.
Resolution: closed superseded
Reason: The maintainer closed the PR because the work was completed by canonical/snapcraft#4955. That Pydantic 2 migration was merged, including commit 1fc8fe6ab.
Evaluated by: mr-cal-bot
No scores available.
Issue body
"GrammarStr" becomes "Grammar[str]", and so on.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by the merged Pydantic 2 refactor in #4955, which completed the intended grammar-model modernization. | |
| stealth/space-bunny-alpha | — | closed superseded | PR closed unmerged by maintainer mr-cal on 2024-10-07: the GenericModel/GrammarStr modernization was completed instead by the Pydantic 2 migration in snapcraft#4955. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as superseded by the merged Pydantic 2 migration in #4955, which completed the generic Grammar type updates. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after the GrammarStr-to-Grammar[str] updates were completed by the Pydantic 2 migration in canonical/snapcraft#4955. | |
| qwen/qwen3.6-35b-a3b | — | — | Superseded by the pydantic 2 refactor (PR #4955). The GrammarStr to Grammar[str] type hint updates were completed in the referenced PR instead. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed and superseded by the pydantic 2 refactor in pull request #4955. Grammar model updates, including replacing GrammarStr with Grammar[str], were implemented in that subsequent PR instead. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#4955
(confidence 100%)
The closing comment explicitly links this merged Pydantic 2 refactor as the completed replacement.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #254 refactor: make pydantic models more idiomatic | craft-archives | open | Refactors Pydantic models to be more idiomatic (fixes #118). Small diff (+42/-23, 5 files). CI passing, but has 1 unresolved review comment with changes_requested status. | |
| #312 refactor: update grammar models | craft-application | closed | Grammar-model refactor PR #312 was closed unmerged with one unresolved review comment; no resolving merge was recorded. |