← Back to issue list

chore!: migrate to pydantic 2

View original Github issue

Metadata

Project
snapcraft
Number
#4955
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged snapcraft#4955 completed the Pydantic 2 migration for CRAFT-3159 and fixed snapcraft#4941; commit 1fc8fe6ab moved dependencies to Pydantic 2.

Resolution: closed resolved

Reason: PR #4955 was merged into snapcraft, with commit 1fc8fe6ab recording the Pydantic 2 dependency migration. The PR explicitly states that it fixes issue #4941 and completes CRAFT-3159.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Migrate to Pydantic 2. Fixes #4941 (CRAFT-3159)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged snapcraft#4955 completed the Pydantic 2 migration for CRAFT-3159 and fixed snapcraft#4941; commit 1fc8fe6ab moved dependencies to Pydantic 2.
stealth/space-bunny-alpha — closed resolved Merged the breaking Pydantic 2 migration, completing CRAFT-3159 and fixing snapcraft#4941.
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI. Migrates the codebase to Pydantic 2, resolving issue #4941. The author rebased and force-pushed clean commits prior to a rebase-merge.
qwen3.6-35b-a3b-mtp-q6 — — Migrated the codebase to Pydantic 2, resolving issue #4941. Commits were cleaned up and rebase-merged by the maintainer.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4941 (confidence 100%)

    The merged PR explicitly identifies #4941 as the issue fixed by the migration.

Related issues

Issue Project State Summary Similarity
#4941 Migrate to Pydantic 2 snapcraft closed Pydantic 2 migration completed in merged snapcraft#4955 via commit 1fc8fe6ab, resolving CRAFT-3159.
90%
#663 chore!: migrate to pydantic 2 rockcraft merged Merged PR #663 migrated Rockcraft to Pydantic 2, adopted craft-application's Platform, and fixed #657; migration work includes commit f1681ea1.
80%
#370 chore(deps): update dependency pydantic to v2 craft-providers closed Renovate pydantic v2 bump closed unmerged by mr-cal to defer migration to a larger craft effort; the upgrade later landed in merged PR #451 (commit f380a9e) for 2.0.
78%
#728 Migrate to Pydantic 2.x craft-parts closed Pydantic 2 migration landed in canonical/craft-parts#771 via commit 6b155294, followed by cleanup in #778; craft-parts now requires pydantic>=2.0.0.
76%
#33 chore!: update to Pydantic 2 craft-grammar merged Merged as commit 5e225fb via PR #33, updating craft-grammar to Pydantic 2 and revising grammar validation errors; fixes #32.
75%
#207 chore(deps): drop Pydantic dependency craft-cli merged PR #207 by tigarmo removed the unused Pydantic dependency from craft-cli's build config (+0/-3 lines across 3 files) and closed issue #201. Merged as commit ce2ee08 after approval from 2 reviewers; Codecov reported no coverage change.
75%
#60 Migrate to pydantic 2 imagecraft merged PR #60 merged as commit be1741a, migrating Imagecraft to Pydantic V2 and newer craft libraries (FR-8917); pyproject now pins pydantic~=2.12.5. Approved by one reviewer with no unresolved comments.
74%
#1817 chore: merge pydantic 2 support to main charmcraft merged Pydantic 2 support was merged into main by PR #1817 (commit 394e6e55), completing the migration begun in #1777 across 52 files.
74%
#28 chore(deps): update dependency pydantic to v2 - autoclosed craft-grammar closed Renovate's Pydantic 2 bump was closed unmerged and superseded by dedicated migration PR #33, which landed in commit 5e225fb.
73%
#771 chore: lift-and-shift update to pydantic 2 craft-parts merged Merged PR #771 as commit 6b155294, completing phase 1 of the Pydantic 2 migration across 38 files using bump-pydantic and follow-up fixes.
73%