← Back to issue list

tests: add tests for advanced grammar in root keywords

View original Github issue

Metadata

Project
snapcraft
Number
#4753
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#4753 via commit 7b01ab01b, adding tests for advanced grammar in root keywords and targeting the 8.2.1 hotfix line.

Resolution: closed resolved

Reason: The test-only PR received two approvals and was merged as commit 7b01ab01b, providing coverage for advanced grammar in root-level keywords.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- ~~Builds on top of https://github.com/canonical/snapcraft/pull/4721, so only look at the last 2 commits.~~ ~~I will retarget this on a `hotfix/8.x` branch such that this can fit into `8.2.1`.~~ LP#2061603 (CRAFT-2817)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#4753 via commit 7b01ab01b, adding tests for advanced grammar in root keywords and targeting the 8.2.1 hotfix line.
stealth/space-bunny-alpha — closed resolved Merged as #4753 (7b01ab01b), adding tests for advanced grammar in root keywords, with two approvals; targeted 8.2.1 and referenced CRAFT-2817.
stealth/space-bunny-alpha — closed resolved Merged PR #4753 (commit 7b01ab01b), adding tests for advanced grammar in root keywords for 8.2.1 (LP#2061603, CRAFT-2817).
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI. Adds test coverage for advanced grammar in root keywords to the hotfix/8.x branch for version 8.2.1, resolving LP#2061603 and CRAFT-2817.
qwen3.6-35b-a3b-mtp-q6 — — Merged tests for advanced grammar in root keywords. Integrated into the hotfix/8.x branch for the 8.2.1 release to address LP#2061603 and CRAFT-2817.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4721 (confidence 90%)

    The PR description originally identified #4721 as its base before retargeting the work to the 8.2.1 hotfix line.

Related issues

Issue Project State Summary Similarity
#4716 test(grammar): new grammar support snapcraft closed PR #4716 (unit tests for new grammar support) was approved but closed unmerged; maintainer @mr-cal closed it because craft-application#296 was merged/released and equivalent Snapcraft tests landed in merged #4768 (c76e626).
72%