test(grammar): new grammar support
Metadata
Current evaluation
PR #4716 (unit tests for new grammar support) was approved but closed unmerged; maintainer @mr-cal closed it because craft-application#296 was merged/released and equivalent Snapcraft tests landed in merged #4768 (c76e626).
Resolution: closed superseded
Reason: Closed by maintainer @mr-cal on 2024-04-29 with an explicit note that craft-application#296 (commit 14ff3d35, grammar-aware PartSpec) had been merged and released, and that the Snapcraft-side test coverage was instead delivered via merged PR #4768 (c76e626), which also fixed #4764.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #4716 (unit tests for new grammar support) was approved but closed unmerged; maintainer @mr-cal closed it because craft-application#296 was merged/released and equivalent Snapcraft tests landed in merged #4768 (c76e626). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged by mr-cal after craft-application PR #296 (grammar support) merged and released; the equivalent Snapcraft tests landed in merged PR #4768 (c76e6267) and #4753. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after craft-application#296 added and released grammar support; equivalent Snapcraft coverage landed in merged #4768. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and superseded after craft-application PR #296 merged and released. Related grammar tests were added via Snapcraft PR #4768. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed and superseded after craft-application#296 merged and released. Required tests were added via snapcraft#4768 instead. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#4768
(confidence 95%)
Merged PR cited by the closing maintainer comment as the place the Snapcraft grammar tests landed (commit c76e626).
-
Related To:
canonical/craft-application#296
(confidence 90%)
Merged upstream feature (14ff3d35) whose release was the stated reason for closing this test-only PR.
-
Related To:
canonical/snapcraft#4753
(confidence 55%)
Merged tests PR (7b01ab01) adding advanced-grammar unit tests in root keywords, overlapping this PR's intent.
-
Related To:
canonical/snapcraft#4764
(confidence 50%)
Regression issue about mixing grammar and plain list entries, fixed alongside by #4768/craft-application 2.6.2.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #328 fix: allow a mix of strings and dicts for grammar | craft-application | merged | Merged craft-application#328 as commit 2a1115d0, allowing grammar lists to mix strings and dicts; released in 2.6.2 and regression-tested by snapcraft#4768. | |
| #3 grammar: import from Snapcraft (CRAFT-818) | craft-grammar | merged | Merged PR #3 (69a12dc) imported the grammar from Snapcraft, updated lint/type tooling, and decoupled GrammarProcessor from ProjectOptions. | |
| #4753 tests: add tests for advanced grammar in root keywords | snapcraft | merged | Merged in canonical/snapcraft#4753 via commit 7b01ab01b, adding tests for advanced grammar in root keywords and targeting the 8.2.1 hotfix line. | |
| #1684 Vendor grammar logic into snapcraft | snapcraft | closed | Advanced grammar was extracted to craft-grammar and adopted by Snapcraft in #3642 (merge 943d130c2), superseding the planned in-tree refactor. | |
| #4768 tests(spread): regression test for grammar and non-grammar lists | snapcraft | merged | Merged PR #4768 (c76e62671) added spread regressions for mixed grammar/non-grammar lists and fixed #4764 through craft-application 2.6.2 parser fixes. |