← Back to issue list

extension: fix issues and depreciated vars in gnome extension

View original Github issue

Metadata

Project
snapcraft
Number
#4798
Type
pull request
State
merged
Author
soumyaDghosh
Labels
Created
Updated
Closed

Current evaluation

Merged changes fixing issues and deprecated variables in the GNOME extension. Approved by two reviewers, passed all CI checks, and modified two files with six additions and six deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes fixing issues and deprecated variables in the GNOME extension. Approved by two reviewers, passed all CI checks, and modified two files with six additions and six deletions.
qwen3.6-35b-a3b-mtp-q6 Merged soumyaDghosh pull request addressing issues and deprecated variables in the GNOME extension. Changes passed linting and Python 3.10 tests before integration.
qwen3.6-35b-a3b-mtp-q6 Merged changes addressing issues and deprecated variables in the GNOME extension. Contributor soumyaDghosh passed lint and test checks before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3178 extensions: add gcc to GNOME 3.28 extension part snapcraft merged Merged changes adding gcc to the GNOME 3.28 extension part. Approved by one reviewer with passing CI checks. The minimal +2/-2 line diff across two files resolves Launchpad bug #1883392.
75%
#3798 extensions: add core22 gnome snapcraft merged Merged into main. Added core22 gnome extension support. Approved by reviewer, passed CI, and increased test coverage by 0.09%. Changes modified 10 files with 707 additions and 1 deletion.
75%
#6260 style: fix gnome extension typing snapcraft merged Merged a fix for GNOME extension typing errors caught by ty. Approved by two reviewers and passing CI, the change resolves the type checking failure in a single file.
75%
#4391 Various Fixes for Gnome Extension snapcraft closed Closed and superseded. Reviewers requested splitting the changes and adding missing unit tests. The author abandoned this PR and recreated it with updated changes.
73%
#2956 Add gnome 3 34 extension snapcraft merged Merged into master, adding GNOME 3.34 extension support. Replaced PR #2794, approved by a reviewer, passed CI, and achieved 100% diff coverage before integration.
73%
#3427 extensions: make GNOME 3.38 stable snapcraft merged Merged after two approvals and passing CI. The change stabilizes GNOME 3.38 in extensions. Despite a minor overall coverage decrease, the maintainer accepted the 100% diff coverage and proceeded with the merge after resolving a publishing failure.
73%
#2706 extensions: improve docsting (used in the cli) snapcraft merged Merged docstring improvements for the gnome-3-28 extension CLI output. Approved with a minor capitalization suggestion noted. The change added 21 lines and removed 2, maintaining existing test coverage.
72%
#3193 extensions: plug the opengl interface for GNOME snapcraft merged Merged following approval and passing CI checks. The change plugs the OpenGL interface for GNOME extensions, adding 18 lines and removing 2 across four files.
72%
#3760 extensions: add core22 gnome snapcraft closed Core22 gnome extension support was closed without merging. Reviewers requested changes with 14 unresolved comments, leaving the contribution abandoned.
71%
#3407 Add new gnome-3-38 extension which uses gnome-3-38-2004 and core20 snapcraft merged Merged into master following reviewer approval and passing CI. Introduces a new gnome-3-38 extension leveraging gnome-3-38-2004 and core20, adding 357 lines across five files with 95.23% change coverage.
71%