← Back to issue list

fix(remote-build): fail if no artifacts are created

View original Github issue

Metadata

Project
snapcraft
Number
#4826
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged fix for issue #4783 that ensures remote builds fail when no artifacts are generated. Approved by two reviewers, passed CI, and merged with 214 additions and 4 deletions across two files.

Suggested action:

No scores available.

Issue body

Fixes #4783 - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix for issue #4783 that ensures remote builds fail when no artifacts are generated. Approved by two reviewers, passed CI, and merged with 214 additions and 4 deletions across two files.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer lengau, this change resolves issue #4783 by ensuring remote builds fail explicitly when no artifacts are generated, preventing silent successes.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve issue #4783. The update modifies remote build logic to explicitly fail when no artifacts are generated, preventing silent build completion without outputs.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4480 fix(remote): return error when remote build failed snapcraft merged Successfully merged fix for remote build failures that returns proper errors, resolving issue #4142. Approved by three reviewers with maintained code coverage across 13 files.
80%
#4432 fix(remote-build): improve logging and catch exceptions snapcraft merged Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399.
79%
#310 fix(remote-build): enable git repo check craft-application merged Successfully merged the fix enabling the git repository check for remote builds. Approved by two reviewers, the update modifies two files with 18 additions and 1 deletion, resolving the build configuration issue.
78%
#2642 remote-build: detect early build errors snapcraft merged Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied.
75%
#4793 fix(remote-build): don't fail with certain archs snapcraft merged Merged a fix for remote-build architecture failures. The changes were retargeted to the hotfix branch per reviewer request before approval and merge.
74%
#351 fix(remotebuild): use full project name in log files craft-application merged Merged a fix ensuring remote build log files use the full project name, resolving issue #4781. Approved by three reviewers, passed CI, and updated two files.
74%
#2594 remote build: don't send log files back to remote snapcraft merged Merged a fix updating build log filters to prevent local logs from being sent to the remote builder. Approved by reviewer, passed CI, and modified two files with four additions and four deletions.
74%
#625 fix(remote-build): don't cleanup after a timeout craft-application merged Merged fix preventing remote builder cleanup after timeouts and removing references to a non-existent --build-id option. Approved by two reviewers, passed CI, and rebased to main for release 4.8.3. Resolves #618 and #619.
73%
#5005 fix(remotebuild): error early for multiple artifacts per build-on snapcraft merged Merged. Adds early validation to prevent Launchpad build failures when multiple artifacts share the same build-on architecture. Replaces cryptic errors with a clear message, resolving issue #4995. Approved and passed CI.
72%
#769 feat: add the remote-build command rockcraft merged Merged the remote-build command. Approved by three reviewers, the change adds 86 lines and removes 7 across nine files. Integrated by the maintainer without further comments or CI issues.
72%