← Back to issue list

nodejs plugin: Allow building N times

View original Github issue

Metadata

Project
snapcraft
Number
#490
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #490 in commit a25b083da, preserving the npm download so the Node.js plugin can build repeatedly and resolve LP #1575882.

Resolution: closed resolved

Reason: PR #490 was merged as commit a25b083da after maintainer approval. Keeping the npm download intact enabled repeated builds and addressed LP #1575882.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Doing this by not deleting the npm download. LP: #1575882 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #490 in commit a25b083da, preserving the npm download so the Node.js plugin can build repeatedly and resolve LP #1575882.
stealth/space-bunny-alpha — closed resolved Merged in #490 as commit a25b083da, retaining the npm download so the Node.js plugin can be built repeatedly and addressing LP #1575882.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#490 (commit a25b083da), preserving the npm download so the Node.js plugin can build repeatedly, addressing LP #1575882.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#490, allowing repeated Node.js plugin builds by retaining the npm download. Resolves LP #1575882.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft PR #490, allowing repeated Node.js plugin builds by retaining the npm download instead of deleting it. Addresses LP #1575882.
qwen/qwen3.6-35b-a3b — — Merged nodejs plugin changes to allow multiple builds by preserving npm downloads instead of deleting them. Approved by @kyrofa and merged after retest requests, resolving LP #1575882.
qwen3.6-35b-a3b-mtp-q6 — — Merged to the nodejs plugin, enabling multiple builds by preserving npm downloads instead of deleting them. Resolves LP #1575882. Approved by @kyrofa after successful retests.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#489 (confidence 80%)

    Adjacent merged PR stopped target cleanup before npm extraction, addressing the same repeated-build behavior.

Related issues

Issue Project State Summary Similarity
#2747 nodejs plugin: fix errors when building in confinement snapcraft merged Merged in #2747 (93fd28257), fixing confined Node.js builds with npm --unsafe-perm, no SUDO_UID, build-time installation, and no npm ls for Yarn.
72%