← Back to issue list

feat: allow numbers in component names

View original Github issue

Metadata

Project
snapcraft
Number
#4945
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged to allow digits in component names and unify validation with snap names. Fixes Launchpad bug #2069783. Approved by two reviewers, CI passed after fixing a doc reference, and depends on craft-parts PR #790.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- - Allows for digits in component names - Refactor to use same validation for snap and component names - Begin snap and component names errors with a lowercase character Depends on https://github.com/canonical/craft-parts/pull/790 Fixes [LP#2069783](https://bugs.launchpad.net/snapcraft/+bug/2069783) (CRAFT-3043)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to allow digits in component names and unify validation with snap names. Fixes Launchpad bug #2069783. Approved by two reviewers, CI passed after fixing a doc reference, and depends on craft-parts PR #790.
qwen3.6-35b-a3b-mtp-q6 Merged. Enables digits in component names, refactors validation to align with snap name rules, and standardizes error formatting. Resolves Launchpad bug #2069783 and depends on craft-parts PR #790. CI and coverage checks passed.
qwen3.6-35b-a3b-mtp-q6 Merged to allow digits in component names and align validation with snap naming rules. Fixes LP#2069783 and depends on craft-parts PR #790. CI issues and review feedback regarding numeric name tests were resolved prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#790 feat: allow numbers in partition names and namespaces craft-parts merged Merged changes enabling numbers and hyphens in partition names and namespaces. Approved by two reviewers and passed CI. Unblocks Launchpad bug LP#2069783. Future hyphen collision handling tracked in issue #789.
76%
#4566 feat(projects): validate component names do not begin with 'snap-' snapcraft merged Merged validation preventing component names from starting with 'snap-', reserved for snapd. Approved by two reviewers, passed CI, and resolves #4538. Unrelated CI failures were addressed in separate PRs.
74%
#202 fix: allow project names to start with multiple digits craft-application merged Merged a fix to allow project names to start with multiple digits, correcting a validation rule that was always intended to permit this. Approved by three reviewers and passed CI checks.
73%
#1701 feat: validate namespaced parts craft-parts merged Validation for namespaced part names was merged to prevent directory conflicts, fixing issue #1016. Approved by two reviewers and integrated after passing CI checks.
71%