← Back to issue list

feat: allow numbers in component names

View original Github issue

Metadata

Project
snapcraft
Number
#4945
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #4945 (commit 8ab7fd0c8) permits digits in component names and shares one validator between snap and component names, fixing LP#2069783. Depends on craft-parts#790.

Resolution: closed resolved

Reason: The PR was approved by two maintainers and merged into main as commit 8ab7fd0c8 ("feat: allow numbers in component names (#4945)"), after updating craft-parts PR #790 to accept digits in partition names.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- - Allows for digits in component names - Refactor to use same validation for snap and component names - Begin snap and component names errors with a lowercase character Depends on https://github.com/canonical/craft-parts/pull/790 Fixes [LP#2069783](https://bugs.launchpad.net/snapcraft/+bug/2069783) (CRAFT-3043)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #4945 (commit 8ab7fd0c8) permits digits in component names and shares one validator between snap and component names, fixing LP#2069783. Depends on craft-parts#790.
stealth/space-bunny-alpha — closed resolved Merged PR #4945 (commit 8ab7fd0c8) allows digits in component names and unifies snap/component name validation, fixing LP#2069783.
qwen/qwen3.6-35b-a3b — — Merged to allow digits in component names and unify validation with snap names. Fixes Launchpad bug #2069783. Approved by two reviewers, CI passed after fixing a doc reference, and depends on craft-parts PR #790.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Enables digits in component names, refactors validation to align with snap name rules, and standardizes error formatting. Resolves Launchpad bug #2069783 and depends on craft-parts PR #790. CI and coverage checks passed.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#790 (confidence 92%)

    Stated dependency; merged as b2128938 allowing numbers in partition names, needed for snapcraft's name validation change

  • Related To: canonical/craft-parts#765 (confidence 35%)

    Earlier related craft-parts change cited in review discussion about an excluded reference

Related issues

Issue Project State Summary Similarity
#2069783 cannot create components with digits in the name snapcraft (launchpad) closed Bug confirmed: component names rejected digits, though snapd allows them. Fixed by PR canonical/snapcraft#4945 (commit 8ab7fd0c8) sharing one validator for snap and component names, after upstream craft-parts#790 (b2128938).
78%
#790 feat: allow numbers in partition names and namespaces craft-parts merged Merged PR #790 (commit b2128938) relaxes partition/namespace name validation to allow numbers; unblocked LP#2069783 (CRAFT-3043). Follow-up for hyphens filed as #789, fixed later by #800.
75%