← Back to issue list

feat: allow numbers in partition names and namespaces

View original Github issue

Metadata

Project
craft-parts
Number
#790
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #790 (commit b2128938) relaxes partition/namespace name validation to allow numbers; unblocked LP#2069783 (CRAFT-3043). Follow-up for hyphens filed as #789, fixed later by #800.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit b2128938 ('feat: allow numbers in partition names and namespaces (#790)') after approval by two reviewers, delivering the CRAFT-3043 validation relaxation and unblocking LP#2069783.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Allow hyphens in partitions, partition namespaces, and namespaced partitions. Unblocks [LP#2069783](https://bugs.launchpad.net/snapcraft/+bug/2069783) (CRAFT-3043)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #790 (commit b2128938) relaxes partition/namespace name validation to allow numbers; unblocked LP#2069783 (CRAFT-3043). Follow-up for hyphens filed as #789, fixed later by #800.
stealth/space-bunny-alpha — closed resolved Merged as b2128938, adding numbers to partition names, namespaces, and namespaced partitions and unblocking LP#2069783. Separate hyphen support landed in #800 (184d5142).
qwen/qwen3.6-35b-a3b — — Merged changes enabling numbers and hyphens in partition names and namespaces. Approved by two reviewers and passed CI. Unblocks Launchpad bug LP#2069783. Future hyphen collision handling tracked in issue #789.
qwen3.6-35b-a3b-mtp-q6 — — Merged to allow numbers and hyphens in partition names and namespaces, unblocking Launchpad bug LP#2069783. Related hyphen and environment variable collision checks are tracked in issue #789.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-parts#789 (confidence 95%)

    Follow-up issue created by the author during review, referenced in code, to allow hyphens in partition names while checking environment variable collisions.

  • Related To: canonical/craft-parts#800 (confidence 90%)

    Merged PR (commit 184d5142) that closed #789 by adding hyphen support in partition names for CRAFT-3031.

Related issues

Issue Project State Summary Similarity
#800 feat: allow hyphens in partition names craft-parts merged Merged PR #800 as commit 184d5142, adding support for hyphens in partition names for CRAFT-3031.
81%
#4945 feat: allow numbers in component names snapcraft merged Merged PR #4945 (commit 8ab7fd0c8) permits digits in component names and shares one validator between snap and component names, fixing LP#2069783. Depends on craft-parts#790.
75%
#801 fix: partitions break when using special characters craft-parts merged Merged PR #801 fixed CRAFT-3031 lifecycle failures for partition names containing numbers and hyphens; merged as commit ceaf4cda.
74%
#1002 feat: Allow slashes in partition names craft-parts merged Merged as c2e41898, allowing slashes in partition names and fixing #999 (CRAFT-4064).
74%
#789 Allow hyphens in partition names craft-parts closed Hyphens enabled in partition names and namespace/partition overlap conflicts validated. Landed via merged PR canonical/craft-parts#800 (commit 184d5142); conflict detection lives in _detect_conflicts().
72%
#1612 feat: allow the plus sign in partition names craft-parts merged Merged PR #1612 as commit 5d5b792a, expanding partition-name validation to permit plus signs used by .deb package names.
72%