← Back to issue list

build(deps): bump craft-parts

View original Github issue

Metadata

Project
snapcraft
Number
#5031
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5031 as commit a24dc3e49, bumping craft-parts to 1.33.1 to fix npm builds when pull and build run separately.

Resolution: closed resolved

Reason: PR #5031 was merged as commit a24dc3e49 and updated craft-parts to 1.33.1. This incorporated the stateless npm plugin fix from craft-parts PR #845, resolving the separate pull/build failure tracked in #844.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This new version fixes a bug on the npm plugin. The bug is caused by the plugin having state that implicitly needs to be passed from the 'pull' step to the 'build' step. If both are done in a single Snapcraft 'run', then it works fine; however, running first 'pull' and then 'build' separately trigger the issue - a failure on the build step. Ref: https://github.com/canonical/craft-parts/issues/844

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5031 as commit a24dc3e49, bumping craft-parts to 1.33.1 to fix npm builds when pull and build run separately.
stealth/space-bunny-alpha — closed resolved Merged as a24dc3e49, bumping craft-parts to 1.33.1 to fix separate pull and build runs failing with the npm plugin.
stealth/space-bunny-alpha — closed resolved Merged PR #5031 (commit a24dc3e49) bumped craft-parts to 1.33.1, fixing npm plugin build failures when pull and build run separately.
qwen/qwen3.6-35b-a3b — — Merged dependency update bumping craft-parts to fix an npm plugin bug where implicit state failed to pass between separate pull and build steps. Approved by two reviewers, passed CI, and integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 — — Merged dependency update bumping craft-parts to fix an npm plugin bug where state failed to pass between separate pull and build steps. Resolves upstream issue #844 and passed all coverage checks.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-parts#844 (confidence 99%)

    Reported the npm plugin state-loss failure when pull and build execute separately.

  • Likely Fixed By: canonical/craft-parts#845 (confidence 98%)

    Merged the stateless npm-plugin fix in commit fab2ecc1, included in the 1.33.x hotfix line.

Related issues

Issue Project State Summary Similarity
#5036 build(deps): bump craft-parts to 1.33.1 snapcraft closed Closed unmerged in favor of canonical/snapcraft#5031, which merged as a24dc3e49 and bumped craft-parts to 1.33.1, making the npm plugin stateless.
89%
#4811 build(deps): bump craft-parts to 1.31.0 snapcraft merged Merged PR #4811 bumped craft-parts to 1.31.0 to add a new set of plugin docs; resolving merge commit a32f01a21.
89%
#1250 build(deps): bump craft-parts to 2.34.0 rockcraft closed PR #1250 was closed unmerged after four CI checks failed; later commit ab4f617f updated craft-parts to 2.35.0 instead.
87%
#5323 build(deps): bump craft-parts to 2.4.3 snapcraft merged Merged #5323 (commit 8c5e558a0) bumped craft-parts to 2.4.3, fixing omitted final stdout or stderr lines.
85%
#6490 build(deps): bump craft-parts to 2.37.2 snapcraft merged Merged PR #6490 bumping craft-parts to 2.37.2 to resolve performance regression #6480 (craft-parts#1760).
85%
#1386 build(deps): bump craft-parts to 2.37.2 rockcraft merged Merged PR #1386 to bump craft-parts to 2.37.2, resolving a file migration performance regression.
85%
#879 build(deps): bump craft-parts rockcraft merged Merged PR #879 in commit 73a95ca5, updating craft-parts to 2.9.1 to fix the "uv version" issue.
85%
#361 build(deps): bump craft-parts from 1.24.1 to 1.25.1 rockcraft merged Merged as commit f7cf0295: bumped craft-parts 1.24.1 -> 1.25.1 in 3 files (+3/-3), picking up the Rust plugin improvements; approved by 2 reviewers.
85%
#373 build(deps): update dependency craft-parts to ~=2.35.0 (main) imagecraft merged Merged PR #373 via commit b31df71, updating craft-parts from ~=2.34.0 to ~=2.35.0.
84%
#575 build(deps): bump craft-parts to 1.31.0 rockcraft merged Dependabot-style bump of craft-parts to 1.31.0 merged into rockcraft main (commit 4cc59da9) via PR #575, 2 approvals; brings new plugin docs.
84%