fix(expand-extensions): use the Application's project
Metadata
Current evaluation
Fixes expand-extensions to use Application's project instead of re-parsing. Approved by 1 reviewer with 2 unresolved comments; merge conflicts resolved 3 days ago via copilot.
Suggested action: needs review
Reason: The PR has 1 approval but 2 unresolved review comments from @mr-cal regarding pydantic validator behavior. Although merge conflicts were auto-resolved 3 days ago, the unresolved review feedback needs maintainer attention before landing.
Impact:
55
Quick Win:
30.25
Staleness:
35
Complexity:
45
Confidence:
70
Issue body
Fixes LP bug https://bugs.launchpad.net/snapcraft/+bug/2083964
Instead of parsing the project again itself, expand-extensions now uses the project provided by the application. The output is changed slightly, but I believe it reflects a more accurate expansion.
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
55
Quick Win:
30.25
Staleness:
35
Complexity:
45
Confidence:
70
|
needs review | Fixes expand-extensions to use Application's project instead of re-parsing. Approved by 1 reviewer with 2 unresolved comments; merge conflicts resolved 3 days ago via copilot. | |
| qwen/qwen3.8-27b |
Impact:
40
Quick Win:
24.0
Staleness:
10
Complexity:
40
Confidence:
80
|
needs review | Refactors expand-extensions to use the Application's parsed project instead of re-parsing snapcraft.yaml, fixing LP bug 2083964. Approved by one reviewer but blocked on merge conflicts and one unresolved review comment; maintainer requested conflict resolution 1 day ago. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
80
Complexity:
20
Confidence:
85
|
close stale | Updates expand-extensions to use the Application's project instead of re-parsing it. Currently inactive for over 10 months, with an unresolved review comment and unchecked contribution checkboxes. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
50
Confidence:
65
|
keep open | Updates expand-extensions to use the Application's project instead of re-parsing, fixing a Launchpad bug. Currently stalled after a maintainer flagged a CI failure related to pydantic validators, with the author acknowledging test changes but no further updates. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
75
Complexity:
40
Confidence:
65
|
needs review | Fixes extension expansion by using the application's project instead of re-parsing it. Stalled due to a test failure where pydantic validators modify build-base/base settings. Awaiting test updates or maintainer review. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1417 fix: expand-extensions overview | charmcraft | merged | Merged into main. This pull request fixes the expand-extensions overview for the craft-application based command, mirroring PR #1416. Approved by two reviewers with passing CI checks, the change modifies one file with five additions and two deletions. | |
| #857 fix(Application): allow loading the project from another dir | craft-application | merged | Merged fix allowing the application to load a project from a different directory. Approved by three reviewers, passed all CI checks, and merged with 49 additions and 10 deletions across four files. | |
| #1367 fix: make application handle a nonexistent project dir | charmcraft | merged | Merged a fix enabling the application to handle nonexistent project directories. Approved by two reviewers and dependent on PR #1364. Changes span 35 files with 989 additions and 252 deletions. |