chore: fix small pyproject.yaml errors
Metadata
Current evaluation
Merged PR #5194 (commit 6a2b36b89) cleaned pyproject.toml: dropped deprecated Ruff rules ANN101/ANN102 and fixed an invalid Black config variable.
Resolution: closed resolved
Reason: The PR was merged into main as commit 6a2b36b89 "chore: fix small pyproject.yaml errors (#5194)". The pickaxe search for ANN101 in pyproject.toml confirms the same commit removed the deprecated Ruff rules, matching the PR's stated scope.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There were two fully deprecated rules being selected for in Ruff's lint rules, as well as an invalid variable name for Black's config. This pull corrects both errors.
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Deleted lint rules: [ANN101](https://docs.astral.sh/ruff/rules/missing-type-self/), [ANN102](https://docs.astral.sh/ruff/rules/missing-type-cls/)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5194 (commit 6a2b36b89) cleaned pyproject.toml: dropped deprecated Ruff rules ANN101/ANN102 and fixed an invalid Black config variable. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5194 (commit 6a2b36b89), removing deprecated Ruff rules ANN101/ANN102 and correcting an invalid Black configuration variable in pyproject.toml. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to pyproject.yaml that remove deprecated Ruff lint rules ANN101 and ANN102, and correct an invalid Black configuration variable. Approved by two reviewers, passed CI checks, and applied minimal code adjustments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for pyproject.yaml errors. Removed deprecated Ruff rules ANN101 and ANN102, and corrected an invalid Black config variable. Lint and tests passed. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/snapcraft#4012
(confidence 70%)
Commit a6e7d5f9d 'linters: migrate to ruff (#4012)' is the earlier commit that introduced the ANN101 select in pyproject.toml, which this PR later removed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #317 chore: update ruff configuration for 0.8 | craft-cli | merged | Merged PR #317 as commit b64b36c, removing two unsupported Ruff rule references from pyproject.toml to align the configuration with Ruff 0.8. | |
| #955 chore: fix some small pyproject errors, include uv.lock | craft-parts | merged | Merged PR #955 (commit 690fe318) fixed deprecated Ruff rules, corrected the git describe argument to an array, and added uv.lock. | |
| #198 chore(deps): update bugfixes | craft-store | merged | Renovate PR #198 merged to main as commit e4ad9ee, bumping dev deps in pyproject.toml: coverage 7.6.0→7.6.1, mypy 1.11.0→1.11.1, pyright 1.1.372→1.1.375, pytest 8.3.1→8.3.2 (+4/-4 lines). | |
| #165 chore(deps): update dependency lint/ruff to v0.1.7 | craft-application | merged | Renovate PR #165 bumped lint/ruff from 0.1.6 to 0.1.7 in pyproject.toml (+1/-1). Approved by 2 reviewers and merged into main as commit 8d5b9926. | |
| #155 chore(deps): update dependency lint/ruff to v0.1.15 | craft-store | merged | Renovate PR merged as commit dbb47aa, bumping lint/ruff in pyproject.toml from ==0.1.9 to ==0.1.15 (+1/-1 line). Approved with no CI failures. | |
| #45 chore(deps): update development dependencies (non-major) | craft-application | merged | Renovate dependency bump PR merged as commit 5c7a5fef: pytest-check 2.1.5→2.2.0, black 23.3.0→23.7.0, pyright-python 1.1.316→1.1.320 (3 lines in pyproject.toml, no code changes). | |
| #24 chore(deps): update patch updates | craft-archives | merged | Renovate patch-bump PR merged (commit 8d16be8): mypy 1.0.0 -> 1.0.1 and ruff 0.0.244 -> 0.0.247 in pyproject.toml. Only comment was a Codecov no-coverage-change notice. | |
| #550 chore: move project configuration to pyproject.toml | rockcraft | closed | Closed unmerged after prolonged inactivity; the configuration migration was later completed by merged PR #751 in commit bc45bedf. | |
| #223 chore(deps): update dependency lint/ruff to v0.1.14 | craft-cli | merged | Renovate dependency bump merged: lint/ruff pin in pyproject.toml moved from ==0.1.8 to ==0.1.14 in commit c40d80e (PR #223), approved with no CI failures. | |
| #42 chore(deps): update development dependencies (non-major) | craft-application | merged | Renovate PR #42 merged via commit 6037992e, bumping dev deps in pyproject.toml (+5/-5 lines): pytest 7.3.2->7.4.0, pytest-mock 3.10.0->3.11.1, codespell 2.2.4->2.2.5, mypy 1.3.0->1.4.1, pyright 1.1.309->1.1.316. |