← Back to issue list

chore: fix some small pyproject errors, include uv.lock

View original Github issue

Metadata

Project
craft-parts
Number
#955
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #955 (commit 690fe318) fixed deprecated Ruff rules, corrected the git describe argument to an array, and added uv.lock.

Resolution: closed resolved

Reason: The changes were merged in PR #955 at commit 690fe318, resolving the pyproject lint and configuration errors and adding the repository lockfile.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The pyproject file referenced some deprecated Ruff linter rules and incorrectly formatted the git describe command parameter, which had to be an array. This PR fixes both, as well as includes a uv.lock file for the repo. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #955 (commit 690fe318) fixed deprecated Ruff rules, corrected the git describe argument to an array, and added uv.lock.
stealth/space-bunny-alpha — closed resolved Merged PR #955 (commit 690fe318) fixed deprecated Ruff rules, corrected the git describe argument to an array, and added uv.lock.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI checks. Fixed deprecated Ruff linter rules, corrected the git describe parameter to an array, and added a uv.lock file.
qwen3.6-35b-a3b-mtp-q6 — — Merged maintainer PR fixing deprecated Ruff linter rules in pyproject, correcting the git describe parameter to an array, and adding a uv.lock file.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5194 chore: fix small pyproject.yaml errors snapcraft merged Merged PR #5194 (commit 6a2b36b89) cleaned pyproject.toml: dropped deprecated Ruff rules ANN101/ANN102 and fixed an invalid Black config variable.
77%
#987 chore: fix CI lint/test blockers and refresh uv.lock craft-providers closed Merged PR #987 refreshed uv.lock and removed duplicate intersphinx overrides from docs/conf.py, fixing docs lint/linkcheck failures and keeping CI green.
76%
#1347 chore(deps): update ruff and fix new linting errors charmcraft merged Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724.
73%
#36 chore: switch to ruff craft-platforms merged Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files.
72%
#115 chore(deps): update ruff and fix linting issue craft-application merged Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking.
72%
#62 chore(deps): update bugfixes starbase merged Merged dependency updates in #62 via commit 1949d4c: Ruff 0.0.256→0.0.267 and Pyright/types 1.1.306→1.1.308.
72%
#439 chore(linter): misc fix rockcraft merged Merged PR #439, applying miscellaneous linter fixes across 16 files, including a Pyright error exposed after rebasing onto main.
72%
#158 chore: fix pyright error craft-archives merged Merged PR #158 as commit fc48bed, fixing a Pyright error with a one-line deletion despite a failing minimum-dependencies job.
72%
#700 chore: update ruff craft-parts merged Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702.
71%
#317 chore: update ruff configuration for 0.8 craft-cli merged Merged PR #317 as commit b64b36c, removing two unsupported Ruff rule references from pyproject.toml to align the configuration with Ruff 0.8.
71%