← Back to issue list

Correct autotools documentation and tests to use configflags

View original Github issue

Metadata

Project
snapcraft
Number
#521
Type
pull request
State
merged
Author
flexiondotorg
Labels
—
Created
Updated
Closed

Current evaluation

Docs fix merged: autotools plugin docs and two test cases corrected to use configflags instead of configure_parameters. Squashed into snapcraft commit 465c38817 after approval from sergiusens and kyrofa.

Resolution: closed resolved

Reason: PR #521 was merged, landing as commit 465c38817 ("Correct autotools tests to use configflags (#521)") in the snapcraft history. Maintainer sergiusens approved the docs/test correction ("OK to test") and kyrofa confirmed the underlying doc bug ("Wow, I never noticed this. :+1:"); the 3-line change updated the autotools docs and two test cases to use the correct configflags key.

Evaluated by: mr-cal-bot

No scores available.

Issue body

As discussed in #snappy IRC on Freenode with `sergiusens` at 13:41:02 on 26th May 2016, here is a pull request to correct the autotools plugin documentation and a couple of test cases.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Docs fix merged: autotools plugin docs and two test cases corrected to use configflags instead of configure_parameters. Squashed into snapcraft commit 465c38817 after approval from sergiusens and kyrofa.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#521, correcting autotools documentation and test cases to use configflags after maintainer approval in May 2016.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#521 (465c38817), correcting autotools documentation and tests to use configflags.
qwen/qwen3.6-35b-a3b — — Merged a fix correcting autotools plugin documentation and test cases to use configflags. Approved by maintainers sergiusens and kyrofa following IRC discussion.
qwen3.6-35b-a3b-mtp-q6 — — Autotools plugin documentation and test cases corrected to use configflags. Merged after maintainer approval and positive review.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1337 (confidence 55%)

    Later commit 714425a34 ('autotools: don't force uniqueness on configflags (#1337)') further refines the same configflags option this PR corrected the docs/tests for.

Related issues

Issue Project State Summary Similarity
#3066 autotools v2 plugin: rename configflags to autotools-configure-parame… snapcraft merged Merged as commit 75dd96faa, renaming the autotools v2 plugin property from configflags to autotools-configure-parameters to clearly namespace it.
72%