chore: clean up some warnings
Metadata
Current evaluation
Merged PR #5281 as commit f24c83d6b, cleaning Python warnings across 21 files and reducing make test-fast warnings from over 3,000 to about 700.
Resolution: closed resolved
Reason: The warning cleanup was merged after two approvals. Squashed commit f24c83d6b addresses most lingering deprecation and pending-deprecation warnings; remaining warnings required riskier changes or originated upstream.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Each commit solves 1 type of warning, sometimes solving the same warning across multiple commits in cases like most code changes being in tests, but one or two things being in live code.
This PR resolves a large majority of lingering deprecation and pending deprecation warnings that come out of a standard run of `make test-fast`. Currently, running that target creates over 3000 warnings. After these changes, about 700 warnings are made.
The warnings I'm leaving behind are ones that either require more risky changes or come from an upstream library.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5281 as commit f24c83d6b, cleaning Python warnings across 21 files and reducing make test-fast warnings from over 3,000 to about 700. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged after two approvals, reducing make test-fast warnings from over 3,000 to about 700; remaining warnings required riskier changes or came from upstream libraries. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a cleanup commit series resolving deprecation warnings across 21 files, cutting test output from over 3000 to 700. Risky changes and upstream warnings were excluded. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup of deprecation warnings across tests and live code, reducing test output from approximately 3000 to 700. Remaining warnings stem from risky refactors or upstream libraries. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #612 chore: cleanup pydantic warnings | craft-providers | merged | Merged PR #612 as commit c106d34, cleaning up Pydantic warnings with a minimal two-file configuration change. | |
| #122 chore: eliminate pydantic warnings | craft-archives | merged | Merged PR #122 eliminated Pydantic warnings, landing as commit 00b9b3b after approval by two reviewers. | |
| #5094 chore: fix deprecation warnings | snapcraft | merged | Merged PR #5094 in commit 0633e5a65, fixing library deprecation warnings across five files (+16/-14 lines). | |
| #5540 chore: resolve deprecation warnings | snapcraft | merged | Merged PR #5540 as commit 93e9c9237, fixing deprecation warnings and closing #5539. | |
| #439 chore(linter): misc fix | rockcraft | merged | Merged PR #439, applying miscellaneous linter fixes across 16 files, including a Pyright error exposed after rebasing onto main. |