chore: clean up some warnings
Metadata
Current evaluation
Merged a cleanup commit series resolving deprecation warnings across 21 files, cutting test output from over 3000 to 700. Risky changes and upstream warnings were excluded. Approved by two reviewers and passed CI.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Each commit solves 1 type of warning, sometimes solving the same warning across multiple commits in cases like most code changes being in tests, but one or two things being in live code.
This PR resolves a large majority of lingering deprecation and pending deprecation warnings that come out of a standard run of `make test-fast`. Currently, running that target creates over 3000 warnings. After these changes, about 700 warnings are made.
The warnings I'm leaving behind are ones that either require more risky changes or come from an upstream library.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a cleanup commit series resolving deprecation warnings across 21 files, cutting test output from over 3000 to 700. Risky changes and upstream warnings were excluded. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup of deprecation warnings across tests and live code, reducing test output from approximately 3000 to 700. Remaining warnings stem from risky refactors or upstream libraries. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup of deprecation and pending deprecation warnings, reducing test output from over 3000 to approximately 700. Remaining warnings were intentionally retained due to high risk or upstream library origins. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #122 chore: eliminate pydantic warnings | craft-archives | merged | Merged after two approvals and passing CI. Refactored three files to eliminate pydantic deprecation warnings, adding 24 lines and removing 15. | |
| #5540 chore: resolve deprecation warnings | snapcraft | merged | Merged to resolve deprecation warnings before they become errors. Updates test mocking context manager setup. Approved by two reviewers and merged despite one failing integration test. Closes #5539. | |
| #5094 chore: fix deprecation warnings | snapcraft | merged | Merged after approval by two reviewers. The change resolves deprecation warnings from external libraries by updating code across five files, ensuring compatibility and preventing future runtime issues. | |
| #2444 chore: clean up unused/unnecessary files | charmcraft | merged | Merged a chore change removing 286 lines across 10 unused files. Approved by two reviewers and integrated despite non-blocking macOS test failures and type checker warnings. | |
| #794 chore: remove pydantic warnings | craft-parts | merged | Successfully merged after approval by two reviewers and passing CI checks. The changes remove pydantic warnings across 9 files, adding 30 lines and deleting 16 to clean up framework deprecation notices. | |
| #2442 chore: fix ruff warnings from test files | charmcraft | merged | Merged following two reviewer approvals. Fixed Ruff deprecation warnings in five test files. CI passed for most checks despite a snap-store-tests failure. Non-blocking type checker notifications required no action. | |
| #923 chore(merge): 2.1.4 into main | craft-parts | merged | Merged release 2.1.4 back into the main branch. Approved by two reviewers with passing CI checks. The update modified 10 files, adding 49 lines and removing 16. | |
| #907 chore(merge): 2.1.3 into main | craft-parts | merged | Merged version 2.1.3 into main following approval from two reviewers and passing CI checks. The change updated seven files, adding 36 lines and removing 10. | |
| #538 chore: merge 0.11.2 | fetch-service | merged | Merged maintainer chore to release version 0.11.2. Approved by two reviewers with all CI checks passing. Changes span four files with minor adjustments (+26/-13 lines). | |
| #2861 chore: remove prime key deprecation warning | charmcraft | merged | Merged following two reviewer approvals. Removes the prime key deprecation warning, resolving issue #1786. The change deletes 24 lines in a single file and passed CI checks. |