← Back to issue list

Migrate validation sets from `snapcraft_legacy` to a craft-application service

View original Github issue

Metadata

Project
snapcraft
Number
#5337
Type
issue
State
closed
Author
mr-cal
Labels
Status: Triaged Type: Refactor
Created
Updated
Closed

Current evaluation

Validation-set migration was completed in merged PR #6050 (commit ddfd7b58b), adding ValidationSetsService and replacing the legacy store client with the modern client.

Resolution: closed resolved

Reason: PR #6050 was merged and resolved the migration from snapcraft_legacy to craft-application and the modern Snapcraft store client. The implementation landed in commit ddfd7b58b.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### What needs to get done * Create a `ValidationSets` service * This is a child of the `Assertion` service, similar to the `Confdbs` service * Migrate models from `snapcraft_legacy.storeapi.v2.validation_sets` to `snapcraft.models.assertions` * Switch from `snapcraft_legacy._store.StoreClientCLI` to `snapcraft.store.StoreClientCLI` * Rewrite unit tests with pytest ### Why it needs to get done - To use a modern store client - To move in-use code out of snapcraft_legacy

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Validation-set migration was completed in merged PR #6050 (commit ddfd7b58b), adding ValidationSetsService and replacing the legacy store client with the modern client.
stealth/space-bunny-alpha — closed resolved Validation-set migration was completed in merged PR #6050 (commit ddfd7b58b), moving validation-sets and edit-validation-sets to ValidationSetsService and the modern store client.
stealth/space-bunny-alpha — closed resolved Validation-set migration was completed: ddfd7b58b added the service migration, and 8d35fd281 migrated the model from snapcraft_legacy.
qwen/qwen3.6-35b-a3b — — Closed without implementation. Triaged and synced to Jira (CRAFT-4338), but no migration work or resolution was recorded.
qwen/qwen3.6-35b-a3b — — Closed without implementation. The requested migration of validation sets to a new service and store client modernization was not completed. No resolution or merge details were provided, indicating the task was abandoned or superseded.
qwen3.6-35b-a3b-mtp-q6 — — Closed without implementation or superseding pull request. The validation sets migration refactor remains unaddressed, with the last recorded activity being an automated Jira synchronization.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#6050 (confidence 99%)

    Merged PR implementing the validation-sets service migration.

Related issues

No related issues found above the similarity threshold.