refactor: migrate validation sets to a service

Metadata

Project: snapcraft
Number: #6050
Type: pull request
State: merged
Author: mr-cal
Labels: PR: Rebase
Created: 2026-02-19 06:04 PM UTC
Updated: 2026-02-20 07:43 PM UTC
Closed: 2026-02-20 07:43 PM UTC

Current evaluation

Merged PR #6050 (commit ddfd7b58b) migrated validation-sets commands to a service and fixed #5337, adding sequence validation and JSON output.

Resolution: closed resolved

Reason: PR #6050 was merged, with squash commit ddfd7b58b, completing the validation-sets service migration. The PR explicitly fixes issue #5337 and passed the required test and lint checks.

Evaluated by: mr-cal-bot

No scores available.

Issue body

I recommend reviewing per-commit. This PR migrates the `validation-sets` and `edit-validation-sets` commands to a service. The new `ValidationSetsService` is a child of the `AssertionService`, which was designed with this task in mind, so the child class is nice and clean. In previous cycles, I made preparations to the legacy code (such as making a pydantic model for validation sets), which greatly reduced the scope of this PR. Behavioral changes: - new help message text - `snapcraft validation-sets --sequence [latest|all]` validates `--sequence` with argparse, rather than sending an invalid sequence to the store and raising the store error - New `--format [table|json]` option for `snapcraft validation-sets` Fixes #5337 (SNAPCRAFT-515) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date	Model	Scores	Action	Summary
2026-10-03 01:17 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged PR #6050 (commit ddfd7b58b) migrated validation-sets commands to a service and fixed #5337, adding sequence validation and JSON output.
2026-10-03 01:17 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged PR #6050 via commit ddfd7b58b, moving validation-sets commands to ValidationSetsService and fixing #5337.
2026-10-03 01:17 AM UTC	stealth/space-bunny-alpha	—	closed resolved	PR #6050 (mr-cal) merged, refactoring `validation-sets`/`edit-validation-sets` commands into a new ValidationSetsService under AssertionService, with argparse --sequence validation and a new --format option. Fixes #5337 (SNAPCRAFT-515); squash commit ddfd7b58b.
2026-09-25 12:15 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged SNAPCRAFT-515, moving validation-sets and edit-validation-sets to ValidationSetsService and fixing #5337. Squash commit: ddfd7b58b.
2026-07-22 01:34 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Merged following review and CI validation. Refactored validation-sets commands into a dedicated ValidationSetsService, improving architecture and adding --format and --sequence validation. Resolves #5337.
2026-07-16 12:39 PM UTC	qwen3.6-35b-a3b-mtp-q6	—	—	Merged after squashing fixup commits. Refactored validation-sets commands into a new ValidationSetsService, added a --format option, improved --sequence validation via argparse, and updated help text. Resolves #5337.

Update history

No update history recorded yet.

Related work

Likely Fixed By: snapcraft#5337 (confidence 100%)
PR #6050 explicitly fixes #5337; merged commit ddfd7b58b completed the migration from snapcraft_legacy.

Related issues

No related issues found above the similarity threshold.