← Back to issue list

Filter out *.snap from sourcedir

View original Github issue

Metadata

Project
snapcraft
Number
#535
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #535 as commit e00f3f376: BasePlugin now filters *.snap files out of plugin.sourcedir, fixing Launchpad bug #1575628. Approved by come-maiz and kyrofa after an unused import was dropped.

Resolution: closed resolved

Reason: PR #535 was merged into snapcraft as commit e00f3f376, adding sourcedir filtering of *.snap files with a unit test in snapcraft/tests/test_base_plugin.py, resolving LP #1575628. Reviewers come-maiz and kyrofa approved once the flagged unused tempfile import was removed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This filters out *.snap when in plugin.sourcedir. LP: #1575628 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #535 as commit e00f3f376: BasePlugin now filters *.snap files out of plugin.sourcedir, fixing Launchpad bug #1575628. Approved by come-maiz and kyrofa after an unused import was dropped.
stealth/space-bunny-alpha — closed resolved Merged PR #535 as commit e00f3f376, filtering *.snap files from plugin.sourcedir to fix LP #1575628. Reviewers approved after an unused import was removed.
qwen/qwen3.6-35b-a3b — — Merged after filtering out *.snap files from the plugin sourcedir to resolve LP: #1575628. Reviewers approved the changes following a minor unused import fix.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Filters out *.snap files from plugin.sourcedir to resolve Launchpad bug #1575628. Approved by maintainers following a minor unused import cleanup.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#534 (confidence 15%)

    No independent confirmation; only the Launchpad bug LP #1575628 is referenced from the PR body.

Related issues

No related issues found above the similarity threshold.