chore(remotebuild): use new build planner
Metadata
Current evaluation
Merged remote build updates to adopt the new get_launchpad_build_plan() and remove unit test xfails. Approved by two reviewers, passed CI checks, and integrated.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
* Uses the new `get_launchpad_build_plan()` added in #5368.
* Removes `xfails` from the remote build unit tests.
Passing remote build spread tests: https://github.com/canonical/snapcraft/actions/runs/14386834165/job/40345445458
(SNAPCRAFT-310)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged remote build updates to adopt the new get_launchpad_build_plan() and remove unit test xfails. Approved by two reviewers, passed CI checks, and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates remote build to use the new get_launchpad_build_plan() function from #5368 and removes outdated xfails from unit tests. All spread tests pass. Resolves SNAPCRAFT-310. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated remote build logic to use the new get_launchpad_build_plan function and removed outdated test xfails. All spread tests passed, completing SNAPCRAFT-310. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4383 chore: rename remote-build test | snapcraft | merged | Merged a code cleanup that renamed the test module to match the source file remote.py. Approved by two reviewers, passed CI checks, and successfully integrated into the main branch. | |
| #6010 chore!: remove remote-build service override | snapcraft | merged | Merged cleanup removing the remote-build service override and manual spread tests. This follow-up addresses overlooked work from PR #5994. Approved by two reviewers, modifying seven files. | |
| #5368 feat: add a BuildPlan service | snapcraft | merged | Merged addition of a BuildPlan service and create_launchpad_build_plan() method to support remote builds. The change adds 847 lines and removes 125 across five files, updates unit tests, and received two reviewer approvals. | |
| #224 fix(remotebuild): create the launchpad instance correctly | craft-application | merged | Approved by two reviewers and passing CI, the fix to correctly create the remotebuild launchpad instance was successfully merged. | |
| #2500 cli: add remote build | snapcraft | merged | Merged. Adds remote build capability to Launchpad, dispatching source trees for remote compilation and retrieving resulting snap packages or logs. Approved by reviewers, passed CI, and integrated despite a minor test coverage decrease. | |
| #4390 chore(remote-build): migrate LaunchpadClient and WorkTree | snapcraft | merged | Merged into main after two approvals and passing CI. Migrates LaunchpadClient and WorkTree classes and tests from snapcraft_legacy, modernizing conventions, updating to pytest, and refactoring GitRepo. Resolves #4323. | |
| #5994 chore!: remove legacy remote builder | snapcraft | merged | Merged changes removing the legacy remote builder, resolving issue #5676. Approved by three reviewers and passing CI checks. The update deletes 3,200 lines across 30 files to clean up deprecated build infrastructure. |