← Back to issue list

chore!: remove remote-build service override

View original Github issue

Metadata

Project
snapcraft
Number
#6010
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Run Manual Spread
Created
Updated
Closed

Current evaluation

Merged #6010 in commit 8bd9cc522, removing the legacy RemoteBuild service override and manual spread tests overlooked by #5994.

Resolution: closed resolved

Reason: PR #6010 was merged as commit 8bd9cc522. It completed the cleanup begun in #5994 by removing the obsolete service override and associated manual spread tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This addresses some overlooked work in #5994. I forgot to remove the RemoteBuild service and manual spread tests. (SNAPCRAFT-1197) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #6010 in commit 8bd9cc522, removing the legacy RemoteBuild service override and manual spread tests overlooked by #5994.
stealth/space-bunny-alpha — closed resolved Merged #6010 (commit 8bd9cc522), removing the remote-build service override and manual spread tests omitted from #5994.
qwen/qwen3.6-35b-a3b — — Merged cleanup removing the remote-build service override and manual spread tests. This follow-up addresses overlooked work from PR #5994. Approved by two reviewers, modifying seven files.
qwen3.6-35b-a3b-mtp-q6 — — Merged cleanup removing the RemoteBuild service override and manual spread tests. Completes follow-up work from PR #5994 and resolves SNAPCRAFT-1197.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5994 (confidence 100%)

    The original legacy remote-builder removal left this service override and its manual tests behind.

Related issues

Issue Project State Summary Similarity
#5994 chore!: remove legacy remote builder snapcraft merged Merged PR #5994 as b08f1a66e, removing the legacy remote builder and closing #5676 for Snapcraft 9.0.
78%
#5390 chore(remotebuild): use new build planner snapcraft merged Merged #5390 (cc63a88b8), migrating remote builds to get_launchpad_build_plan() from #5368 and removing remote-build test xfails.
73%
#4383 chore: rename remote-build test snapcraft merged Merged PR #4383 (commit 4f7f4a58a) renamed tests/unit/commands/test_remote_build.py to test_remote.py so the test module name matches snapcraft/commands/remote.py. Pure rename, no functional change.
70%
#2682 chore: delete some dead code charmcraft merged Merged PR #2682 that removes 19 lines of dead code related to the project-service cast issue fixed in #2681.
70%