← Back to issue list

Rename strip to prime

View original Github issue

Metadata

Project
snapcraft
Number
#543
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #543 by sergiusens merged the rename of the lifecycle 'strip' step to 'prime' across 31 files (+299/-295), fixing Launchpad bug #1582515. Commit 1540773f1; approved by kyrofa who noted unit and integration test coverage.

Resolution: closed resolved

Reason: The pull request itself was merged into snapcraft master as commit 1540773f1 ("Rename strip to prime (#543)"), satisfying the linked Launchpad bug #1582515. Reviewer kyrofa approved with +1 citing unit and integration test coverage.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1582515 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #543 by sergiusens merged the rename of the lifecycle 'strip' step to 'prime' across 31 files (+299/-295), fixing Launchpad bug #1582515. Commit 1540773f1; approved by kyrofa who noted unit and integration test coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #543 in June 2016, renaming strip to prime across 31 files and resolving Launchpad bug #1582515.
qwen/qwen3.6-35b-a3b — — Merged the rename of strip to prime across 31 files. Approved by @kyrofa citing adequate test coverage. Resolves LP: #1582515.
qwen3.6-35b-a3b-mtp-q6 — — Merged after approval by @kyrofa. The change renaming strip to prime was validated by unit and integration tests, successfully updating the codebase terminology.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1279 (confidence 40%)

    Later cleanup commit 'misc: rename the snap dir variable to prime dir (#1279)' continues the same strip-to-prime naming alignment.

Related issues

Issue Project State Summary Similarity
#696 Replace 'strip' with 'prime' on intro page and step options. snapcraft merged Merged snapcraft#696 as commit a40121ad7, replacing stale "strip" references with "prime" on the intro page and lifecycle step options.
78%
#1582515 strip phase name is not great snapcraft (launchpad) closed Renamed the lifecycle step/directory 'strip' to 'prime' via snapcraft PR #543 (commit 1540773f1), shipping in snapcraft 2.10; 'strip' kept as a deprecated alias. Follow-up #556 (83de1df03, 2.10.1) fixed clean --step=strip.
74%