← Back to issue list

strip phase name is not great

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1582515
Type
issue
State
closed
Author
~niemeyer
Labels
verification-done
Created
Updated
Closed

Current evaluation

Renamed the lifecycle step/directory 'strip' to 'prime' via snapcraft PR #543 (commit 1540773f1), shipping in snapcraft 2.10; 'strip' kept as a deprecated alias. Follow-up #556 (83de1df03, 2.10.1) fixed clean --step=strip.

Resolution: closed resolved

Reason: After discussion the team agreed on 'prime' for both the step name and the prime/ directory, with 'snap' building the .snap file; implemented in ubuntu-core/snapcraft PR #543 (commit 1540773f1 'Rename strip to prime'). janitor marked it fixed in package snapcraft 2.10+16.10 and elopio verified, tagging verification-done; a regression (clean -s strip) was separately fixed in 2.10.1 (#556, LP #1590256).

Evaluated by: mr-cal-bot

No scores available.

Issue body

The "strip" phase name is not great. It's not actually stripping.. it's the phase that copies the content into the snap directory, as I understand it. So it's the opposite of stripping (although I understand where the motivation comes from). See how this command makes little sense, for example:     snapcraft clean --step=strip So it might be better named as something like "cast", or "shape", or "form". I'd check with Mark for the best word here. [Impact] * One of the snapcraft commands is confusing. * The change is backwards compatible, so anything that's relying on strip will still work. [Test Case] * Run snapcraft strip * Check that you get a deprecation message. * Clean * Run snapcraft prime * Check that the results are the same, without deprecation message. [Regression Potential] * This could affect the strip command.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Renamed the lifecycle step/directory 'strip' to 'prime' via snapcraft PR #543 (commit 1540773f1), shipping in snapcraft 2.10; 'strip' kept as a deprecated alias. Follow-up #556 (83de1df03, 2.10.1) fixed clean --step=strip.
stealth/space-bunny-alpha — closed resolved Rename of the "strip" lifecycle step to "prime" landed in merged PR #543 (snapcraft 2.10); follow-up PR #556 restored `snapcraft clean -s strip` backwards compatibility.
stealth/space-bunny-alpha — closed resolved Renamed Snapcraft’s misleading strip phase to prime in merged PR #543 (1540773f1), preserving strip as a deprecated alias. Follow-up PR #556 covered clean compatibility.
qwen/qwen3.6-35b-a3b — — Renamed the confusing strip phase to prime in snapcraft. Backwards compatibility is preserved through a deprecation warning for the original command. The fix was verified and the issue closed.
qwen/qwen3.6-35b-a3b — — The strip phase was renamed to prime to accurately describe copying content into the snap directory. The legacy strip command was deprecated with a backwards-compatible warning. Verification completed.
qwen/qwen3.6-35b-a3b — — Renamed the confusing strip phase to prime. Backwards compatibility is preserved through a deprecation warning. The change was implemented, verified, and the issue closed.
qwen3.6-35b-a3b-mtp-q6 — — The strip phase was renamed to prime to better reflect its function. The original strip command was deprecated with backwards compatibility maintained. The fix was verified and the issue closed.

Update history

Date Change
created

Related work

  • Likely Fixed By: ubuntu-core/snapcraft#543 (confidence 97%)

    PR linked by sergiusens implementing the strip -> prime rename; commit 1540773f1.

  • Related To: snapcraft (launchpad)#1590256 (confidence 90%)

    Regression found during verification: clean --step=strip rejected; fixed by #556 (commit 83de1df03) in 2.10.1.

  • Related To: ubuntu-core/snapcraft#696 (confidence 45%)

    Docs follow-up replacing 'strip' with 'prime' in the intro page and step options (commit a40121ad7).

Related issues

Issue Project State Summary Similarity
#696 Replace 'strip' with 'prime' on intro page and step options. snapcraft merged Merged snapcraft#696 as commit a40121ad7, replacing stale "strip" references with "prime" on the intro page and lifecycle step options.
76%
#1604239 Strip is used instead of prime in the snapcraft document snapcraft (launchpad) closed Documentation was corrected from strip to prime by merged snapcraft PR #696, commit a40121ad7.
75%
#1794855 Remove snap and strip keyword snapcraft (launchpad) closed Merged snapcore/snapcraft#2344 (commit f2cdc5e8a) removed deprecated snap/strip keyword handling, leaving prime as intended.
74%
#543 Rename strip to prime snapcraft merged PR #543 by sergiusens merged the rename of the lifecycle 'strip' step to 'prime' across 31 files (+299/-295), fixing Launchpad bug #1582515. Commit 1540773f1; approved by kyrofa who noted unit and integration test coverage.
74%
#556 Backwards compatible clean with strip snapcraft merged Merged PR #556 via commit 83de1df03, making clean -s strip call prime with a deprecation warning; released in snapcraft 2.10.1.
71%