← Back to issue list

ci: add check for each manual spread test job

View original Github issue

Metadata

Project
snapcraft
Number
#5434
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged CI configuration changes adding explicit checks for manual spread test jobs. This prevents jobs from incorrectly showing as skipped when the manual label is absent. Approved by reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- We thought we could get away without these extra lines, but we need them. These extra checks needs to be present or else these jobs show as "skipped" when the manual spread label isn't added. For example: ![image](https://github.com/user-attachments/assets/7eacc7ab-6357-4889-8c88-b7ac8ba991b6)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged CI configuration changes adding explicit checks for manual spread test jobs. This prevents jobs from incorrectly showing as skipped when the manual label is absent. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged changes add CI checks for each manual spread test job. These checks prevent jobs from incorrectly showing as skipped when the manual spread label is absent, ensuring accurate test execution tracking.
qwen3.6-35b-a3b-mtp-q6 Merged CI configuration updates adding explicit checks for each manual spread test job. This prevents jobs from incorrectly displaying as skipped when the manual spread label is not applied.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5714 ci: update label for manual spread tests snapcraft merged Merged after reviewer approval. Updates CI configuration to use a new terraform-managed label for manual spread tests. All required checks passed and the change was successfully integrated.
79%
#1034 ci: make manual spread more cooperative rockcraft merged Merged after two approvals and passing all CI checks. The change updates CI configuration to make manual spread more cooperative. Marked as a duplicate of PR #5880.
78%
#2487 ci: add manual spread label, match other crafts charmcraft merged Merged. Adds the 'PR: Run Manual Spread' label to standardize manual spread workflows across crafts. Approved by two reviewers despite unrelated CI failures, which were deemed out of scope. Two-file change with non-blocking type warnings.
75%
#5880 ci: make manual spread label more cooperative snapcraft merged Merged a CI workflow update improving manual spread label handling. The change ensures the workflow triggers on label addition, runs on subsequent commits, supports manual dispatch, and respects removal. Approved and merged.
74%
#6335 ci: always discard spread workers in manual tests (main) snapcraft merged Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file.
74%
#573 ci: run spread tests on 'spread-installed' runners rockcraft merged Merged a two-file, four-line CI configuration change to run spread tests on spread-installed runners. Approved by three reviewers and integrated.
73%
#801 test(spread): mark doc tests as manual rockcraft open Marks doc spread tests as manual so they don't run on every code change. Pending review, 0 comments, no CI. Docs tests now run via a separate conditional workflow (spread-docs.yaml) on a weekly schedule and only when docs code changes.
72%
#1083 ci: fix spread test missing PATH charmcraft merged Merged a fix for a CI spread test missing the PATH variable. The change updated four files and received reviewer approval. Post-merge validation confirmed the spread tests for configure and remove passed successfully.
72%
#1220 ci: always run spread workflow on schedule rockcraft merged Merged CI configuration updates ensuring the full Spread test suite always runs on the scheduled bi-daily workflow for the main branch, preventing automatic skips. Approved by one reviewer and passed all checks.
72%
#863 ci: run spread tests on hotfix branches craft-application merged Merged CI configuration enabling spread tests on hotfix branches. Approved by two reviewers with all checks passing. Eliminates the admin override requirement for hotfix branch creation with a single line change.
72%