← Back to issue list

ci: always discard spread workers in manual tests (main)

View original Github issue

Metadata

Project
snapcraft
Number
#6335
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file.

Suggested action:

No scores available.

Issue body

This PR adds the 'Discard spread workers' cleanup step to each of the manual testing jobs in the 'spread-manual.yaml' workflow. Without this step, if any of these jobs are cancelled or crash, the remote Google Cloud VM instances allocated by 'spread' are leaked and remain active until the halt timeout (2h). Adding this step mirrors the cleanup behavior in the other workflows of the repository. SNAPCRAFT-1368

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 10
Confidence: 90
needs review Adds a cleanup step to discard spread workers in manual CI tests to prevent leaked GCP VM instances on cancellation or crash. Awaiting maintainer review.

Update history

Date Change
updated

Related issues

Issue Project State Summary Similarity
#2771 ci: always discard spread workers in snap-store-tests (main) charmcraft merged Merged CI fix adding cleanup to discard spread workers in snap-store-tests. Prevents Google Cloud VM leaks on cancellation or crash, aligning with other jobs. Approved and merged despite minor CI failures.
84%
#115 ci: always discard spread workers in build-rock tests (core22-8) snapcraft-rocks merged Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers.
82%
#117 ci: always discard spread workers in build-rock tests (core24-8) snapcraft-rocks merged Merged changes add a cleanup step to discard spread workers in the build-rock workflow, preventing leaked Google Cloud VM instances on cancellation or crash. Resolves SNAPCRAFT-1368.
77%
#482 ci: always discard spread workers rockcraft merged Merged a CI workflow update to always discard spread workers, ensuring cleanup even on workflow cancellation. This change mirrors snapcraft's spread configuration.
76%
#1519 ci: always discard spread runners charmcraft merged Merged a CI workflow update that permanently discards spread runners by mirroring the snapcraft repository configuration. Approved by three reviewers, the change adds 16 lines to a single workflow file.
75%
#5434 ci: add check for each manual spread test job snapcraft merged Merged CI configuration changes adding explicit checks for manual spread test jobs. This prevents jobs from incorrectly showing as skipped when the manual label is absent. Approved by reviewers and passed all CI checks.
74%
#2770 ci: always discard spread workers in snap-store-tests charmcraft closed Abandoned without merge. The change to add a cleanup step preventing CI VM leaks in snap-store-tests received no reviews and was closed.
73%
#116 ci: always discard spread workers in build-rock tests (core22-7) snapcraft-rocks open Adds spread worker cleanup step to build-rock.yaml workflow to prevent leaked GCP VM instances. Inactive 56 days with unresolved review comment and failing CI checks.
73%
#2126 ci(docs): spread test documentation charmcraft merged Merged changes adding a CI workflow for spread testing documentation and adjusting tasks for Google runners. Approved by two reviewers, the update modifies five files (+100/-22 lines) and resolves CRAFT-3798.
71%
#862 tests: bootstrap spread charmcraft merged Merged changes adding spread test bootstrap configuration. Enables local execution of spread tests on Google Cloud VMs. Approved by one reviewer, passed CI, and introduced 78 lines across four files.
71%