ci: always discard spread workers in manual tests (main)
Metadata
Current evaluation
Merged #6335 in commit b36b3c325, adding always-run Spread worker cleanup to manual CI jobs so cancelled or crashed tests do not leak GCP VMs.
Resolution: closed resolved
Reason: PR #6335 was merged into main as commit b36b3c325. It adds an always-executed worker discard step to each manual testing job, preventing allocated cloud VMs from remaining active after cancellation or failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This PR adds the 'Discard spread workers' cleanup step to each of the manual testing jobs in the 'spread-manual.yaml' workflow.
Without this step, if any of these jobs are cancelled or crash, the remote Google Cloud VM instances allocated by 'spread' are leaked and remain active until the halt timeout (2h). Adding this step mirrors the cleanup behavior in the other workflows of the repository.
SNAPCRAFT-1368
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #6335 in commit b36b3c325, adding always-run Spread worker cleanup to manual CI jobs so cancelled or crashed tests do not leak GCP VMs. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #6335 adds always-run spread worker cleanup to manual CI test jobs, preventing Google Cloud VMs from leaking after cancellation or crashes. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
10
Confidence:
90
|
needs review | Adds a cleanup step to discard spread workers in manual CI tests to prevent leaked GCP VM instances on cancellation or crash. Awaiting maintainer review. |
Update history
| Date | Change |
|---|---|
| updated |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2771 ci: always discard spread workers in snap-store-tests (main) | charmcraft | merged | Merged PR #2771 (main) adds an always-run "Discard spread workers" cleanup step to the snap-store-tests job in spread.yaml, so cancelled/crashed CI runs no longer leak GCE VMs until the 2h halt timeout. | |
| #117 ci: always discard spread workers in build-rock tests (core24-8) | snapcraft-rocks | merged | Merged PR #117 (core24-8) adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in build-rock.yaml, so cancelled/crashed jobs don't leak GCP VMs for 2h (SNAPCRAFT-1368). Approved; +8/-0. | |
| #115 ci: always discard spread workers in build-rock tests (core22-8) | snapcraft-rocks | merged | PR #115 merged (+8/-0): adds an always-run 'Discard spread workers' step to the spread-tests job in .github/workflows/build-rock.yaml for core22-8, so cancelled/crashed jobs no longer leak spread GCP VMs (SNAPCRAFT-1368). | |
| #116 ci: always discard spread workers in build-rock tests (core22-7) | snapcraft-rocks | open | Adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in .github/workflows/build-rock.yaml (core22-7) so GCP VMs aren't leaked on cancellation (SNAPCRAFT-1368). +8/-0, spread-tests green, build-rock amd64/arm64 failing. | |
| #1519 ci: always discard spread runners | charmcraft | merged | Merged #1519 (commit fdf24383), adding post-job cleanup to the Spread workflow so temporary runners are always discarded after CI jobs. | |
| #5434 ci: add check for each manual spread test job | snapcraft | merged | Merged PR #5434 in commit c6a67da45, adding checks so manual Spread test jobs no longer appear skipped when their label is absent. | |
| #482 ci: always discard spread workers | rockcraft | merged | PR #482 by lengau merged: added an always-run "Discard spread workers" cleanup step (spread -discard -reuse-pid) to .github/workflows/spread.yaml, copied from snapcraft's spread.yml. | |
| #2126 ci(docs): spread test documentation | charmcraft | merged | Merged PR #2126 in commit f1b73a6e, adding CI for documentation spread tests and adapting spread tasks for Google-hosted runners. |