build: add patchelf to make dependencies
Metadata
Current evaluation
Merged PR #5486 (commit 8ae6349b9) adds the patchelf apt package to the Make dev dependencies, fixing test failures on self-hosted CI runners where patchelf was missing.
Resolution: closed resolved
Reason: PR #5486 was approved and merged as commit 8ae6349b9 ("build: add patchelf to make dependencies (#5486)"), a +3-line Makefile change installing the patchelf apt package when the development environment is created. Fast/slow test, lint, publish and security-scan checks all passed; only the unrelated google-runner spread integration jobs remained red.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
Since switching to the self-hosted runners, tests have been breaking because patchelf wasn't installed on them. For example, see [this workflow](https://github.com/canonical/snapcraft/actions/runs/14932815042). This PR just adds the apt package to be installed during the creation of the development environment.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5486 (commit 8ae6349b9) adds the patchelf apt package to the Make dev dependencies, fixing test failures on self-hosted CI runners where patchelf was missing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5486 (commit 8ae6349b9), adding the patchelf apt package to Make development dependencies so self-hosted runner tests have the required ELF patching tool. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #5486 (commit 8ae6349b9), adding patchelf to the Make development dependencies to support self-hosted test runners. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to add patchelf to development environment dependencies, resolving test failures on self-hosted runners. Approved by two reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve failing tests on self-hosted runners. Added patchelf to the development environment dependencies, ensuring consistent build execution. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1888 elf: make patchelf a dependency | snapcraft | merged | Merged PR #1888 via commit 7c947f5ec, moving Patchelf out of project_loader build tools and into the deb and snap delivery mechanisms. | |
| #1967 project_loader: improve the logic to install patchelf as a build tool | snapcraft | merged | Merged PR #1967 as commit 84aaac591, improving patchelf build-tool installation and excluding broken Xenial armhf/s390x packages. | |
| #5135 fix(test): add patchelf to dev dependencies for testing | snapcraft | closed | Closed unmerged as obsolete after #5225 superseded the proposed patchelf test dependency; the Starflow migration merged in commit 7a1a94e46. |