Reenable get and set tourdir unit tests
Metadata
Current evaluation
Merged PR #551 as commit 4ae5e7a09, re-enabling tourdir getter/setter tests and resetting internal directory paths via cleanup to remove order dependence.
Resolution: closed resolved
Reason: The changes were merged in commit 4ae5e7a09. They restored the tourdir unit tests and added cleanup that resets internal directory variables after each test.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The existing tests (also for plugin dir) were running order dependant.
Ensure we reset the state to default for all internal variables.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #551 as commit 4ae5e7a09, re-enabling tourdir getter/setter tests and resetting internal directory paths via cleanup to remove order dependence. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #551 as commit 4ae5e7a09, restoring tourdir unit tests with cleanup that resets internal directory variables and removes order dependence. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Re-enables unit tests for get and set tourdir by resetting internal variables to defaults via addCleanup. Fixes order-dependent test failures. Changes were reviewed, rebased, and merged after passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after fixing order-dependent unit tests by resetting internal state variables. The author implemented addCleanup in setUp() for proper teardown, rebased the branch, and passed final checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #559 Reenable tour command | snapcraft | merged | Merged in #559 via cadeb87ea, restoring snapcraft tour with non-nesting directory logic plus unit and integration tests. | |
| #624 test: use `new_dir` fixture | craft-parts | merged | Merged PR #624 as commit d214d9d8, updating two unit tests to use new_dir so test files no longer pollute the repository working directory. | |
| #547 Skip the tour dir unittest. | snapcraft | merged | PR #547 was merged as commit f60357af5, adding three lines to skip the tour-directory unit test. |