← Back to issue list

Reenable get and set tourdir unit tests

View original Github issue

Metadata

Project
snapcraft
Number
#551
Type
pull request
State
merged
Author
didrocks
Labels
Created
Updated
Closed

Current evaluation

Merged. Re-enables unit tests for get and set tourdir by resetting internal variables to defaults via addCleanup. Fixes order-dependent test failures. Changes were reviewed, rebased, and merged after passing CI checks.

Suggested action:

No scores available.

Issue body

The existing tests (also for plugin dir) were running order dependant. Ensure we reset the state to default for all internal variables.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Re-enables unit tests for get and set tourdir by resetting internal variables to defaults via addCleanup. Fixes order-dependent test failures. Changes were reviewed, rebased, and merged after passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged after fixing order-dependent unit tests by resetting internal state variables. The author implemented addCleanup in setUp() for proper teardown, rebased the branch, and passed final checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Resolved order-dependent unit tests by resetting internal state to defaults via addCleanup in setUp(). Code updated per reviewer feedback, rebased on master, and approved.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#559 Reenable tour command snapcraft merged Merged the reenabled snapcraft tour command. Implemented logic to prevent nested default directories and added integration tests for primary use cases. All review comments were resolved and CI passed prior to merge.
75%