Reenable tour command
Metadata
Current evaluation
Merged in #559 via cadeb87ea, restoring snapcraft tour with non-nesting directory logic plus unit and integration tests.
Resolution: closed resolved
Reason: PR #559 was merged as commit cadeb87ea, re-enabling the tour command and adding logic and tests to prevent repeated commands from nesting default directories.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Reenable "snapcraft tour" command with tests.
Added a small logic enhancements backed up with tests to ensure we don't nest default directory inside each other for multiple commands run.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #559 via cadeb87ea, restoring snapcraft tour with non-nesting directory logic plus unit and integration tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #559 (cadeb87ea), re-enabling `snapcraft tour` with logic preventing nested default directories, plus unit and integration tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the reenabled snapcraft tour command. Implemented logic to prevent nested default directories and added integration tests for primary use cases. All review comments were resolved and CI passed prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the reenabled snapcraft tour command. Added logic to prevent nested default directories and comprehensive integration and unit tests. Approved after multiple test requests and final reviewer sign-off. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1590906 Enable the `snapcraft tour` command | snapcraft (launchpad) | closed | `snapcraft tour` was re-enabled by PR #559 (commit cadeb87ea, "Reenable tour command"), merged by Didier Roche and released in snapcraft 2.11 to xenial -updates; SRU verification passed and LP bug janitored. | |
| #551 Reenable get and set tourdir unit tests | snapcraft | merged | Merged PR #551 as commit 4ae5e7a09, re-enabling tourdir getter/setter tests and resetting internal directory paths via cleanup to remove order dependence. | |
| #1217 tour: make it work when its a snap. | snapcraft | merged | Merged PR #1217 in commit d365eb9ed, fixing tour bootstrapping and repository detection when Snapcraft runs as a snap; resolves LP #1674952. | |
| #1586137 Snapcraft should provide an `tour` subcommand that sets up a basic tour | snapcraft (launchpad) | closed | Implemented in Snapcraft 2.10: PR #513 (7f334a5b1) added the getting-started tour, and PR #559 (cadeb87ea) re-enabled the completed command; verification passed. | |
| #1324 Revert "tests: remove the reusable parts tour test (#1321)" | snapcraft | merged | Merged PR #1324 (commit fbb228aa8) restored the reusable-parts tour test by reverting #1321 after the failure was traced to Snapcraft rather than the tested code. |