extensions/gnome: Add sdk include directories to C_INCLUDE_PATH
Metadata
Current evaluation
Adds GNOME SDK header paths to C_INCLUDE_PATH and updates tests/docs. Most CI passes, but maintainers say it could break stable core24 builds and should wait for Snapcraft 9/core26.
Suggested action: close not mergeable
Reason: The author acknowledged existing builds could break; lengau cited the contract that unchanged files must continue building, and bepri explicitly said the change should be delayed until Snapcraft 9/core26. Despite one recorded approval, the Ubuntu 22.04 integration job is also failing, so the current stable-extension form is not acceptable to merge.
Evaluated by: mr-cal-bot
Impact:
52
Quick Win:
5
Complexity:
44
Confidence:
95
Actionability:
18
Issue body
The sdk provides a base /usr/include path that should be checked when an including from the default paths.
Without this, when a file is including something such as
```c
#include <xkbcommon/xkbcommon.h>
```
that is provided by /snap/gnome-46-2404-sdk/current/usr/include, the compiler won't look for such path at all.
There's no need to fallback to default `/usr/include` because such path is always included anyways by gcc (at least when that's compiled with such prefix).
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha |
Impact:
52
Quick Win:
5
Complexity:
44
Confidence:
95
Actionability:
18
|
close not mergeable | Adds GNOME SDK header paths to C_INCLUDE_PATH and updates tests/docs. Most CI passes, but maintainers say it could break stable core24 builds and should wait for Snapcraft 9/core26. | |
| qwen/qwen3.6-35b-a3b |
Impact:
50
Quick Win:
12
Complexity:
20
Confidence:
75
Actionability:
30
|
close stale | Adds SDK include directories to C_INCLUDE_PATH for GNOME extension; approved but maintainers requested delay until core26; inactive 346 days. | |
| qwen/qwen3.8-27b |
Impact:
45
Quick Win:
27
Staleness:
45
Complexity:
40
Confidence:
80
|
keep open | Adds GNOME SDK include dirs to C_INCLUDE_PATH in the gnome extension so headers like xkbcommon/xkbcommon.h resolve. Approved by one reviewer, but maintainers (lengau, bepri) deferred it to core26/Snapcraft 9 over core24 backward-compat risk; one CI job failing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
80
Complexity:
25
Confidence:
95
|
keep open | Adds GNOME SDK include directories to C_INCLUDE_PATH to fix compiler path resolution. Maintainers requested deferring the change until core26/Snapcraft 9 due to backward compatibility risks for existing core24 builds. Currently on hold. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
20
Confidence:
90
|
keep open | Adds GNOME SDK include directories to C_INCLUDE_PATH to resolve missing header errors. Maintainers requested delaying the change until Snapcraft 9/core26 due to build compatibility concerns. Currently inactive pending the next major release. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5589 fix(gnome): update cmake prefix path | snapcraft | merged | Merged PR #5589 (commit d30f563a7) fixed the GNOME extension's CMAKE_PREFIX_PATH to point at $CRAFT_STAGE/usr and the SDK snap's usr dir, a follow-up to #5272; released in snapcraft 8.10.1. | |
| #5461 feat(gnome): add cmake prefix path | snapcraft | merged | Merged PR #5461 (commit a3f33196f) added CMAKE_PREFIX_PATH=$CRAFT_STAGE/usr to the GNOME extension build environment, fixing #5272. Follow-up #5589 (d30f563a7) added the SDK usr prefix; shipped in snapcraft 8.10.1. |