extensions/gnome: Add sdk include directories to C_INCLUDE_PATH
Metadata
Current evaluation
Adds GNOME SDK include dirs to C_INCLUDE_PATH in the gnome extension so headers like xkbcommon/xkbcommon.h resolve. Approved by one reviewer, but maintainers (lengau, bepri) deferred it to core26/Snapcraft 9 over core24 backward-compat risk; one CI job failing.
Suggested action: keep open
Reason: Maintainers bepri and lengau explicitly deferred this to Snapcraft 9/core26 rather than rejecting it, and the 'Needs information' label plus the author's active reply (2025-10-01) show it is under discussion, not dead. The change is still relevant (no C_INCLUDE_PATH exists in the current gnome.py) and is intentionally held for a future base, so it should stay open pending the core26 work.
Impact:
45
Quick Win:
27.0
Staleness:
45
Complexity:
40
Confidence:
80
Issue body
The sdk provides a base /usr/include path that should be checked when an including from the default paths.
Without this, when a file is including something such as
```c
#include <xkbcommon/xkbcommon.h>
```
that is provided by /snap/gnome-46-2404-sdk/current/usr/include, the compiler won't look for such path at all.
There's no need to fallback to default `/usr/include` because such path is always included anyways by gcc (at least when that's compiled with such prefix).
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.8-27b |
Impact:
45
Quick Win:
27.0
Staleness:
45
Complexity:
40
Confidence:
80
|
keep open | Adds GNOME SDK include dirs to C_INCLUDE_PATH in the gnome extension so headers like xkbcommon/xkbcommon.h resolve. Approved by one reviewer, but maintainers (lengau, bepri) deferred it to core26/Snapcraft 9 over core24 backward-compat risk; one CI job failing. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
80
Complexity:
25
Confidence:
95
|
keep open | Adds GNOME SDK include directories to C_INCLUDE_PATH to fix compiler path resolution. Maintainers requested deferring the change until core26/Snapcraft 9 due to backward compatibility risks for existing core24 builds. Currently on hold. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
20
Confidence:
90
|
keep open | Adds GNOME SDK include directories to C_INCLUDE_PATH to resolve missing header errors. Maintainers requested delaying the change until Snapcraft 9/core26 due to build compatibility concerns. Currently inactive pending the next major release. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
85
Complexity:
20
Confidence:
80
|
close stale | Adds GNOME SDK include directories to C_INCLUDE_PATH to fix missing header resolution. Maintainers consider it risky for existing core24 builds and have deferred the change until core26/Snapcraft 9. Currently pending release. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5515 feat(gnome): Add SNAPCRAFT_GNOME_SDK env | snapcraft | merged | Merged addition of the SNAPCRAFT_GNOME_SDK environment variable to expose the GNOME SDK snap path, eliminating hardcoded values. Approved by three reviewers and passing CI, the change modifies three files with six lines added. |