← Back to issue list

fix(gnome): update cmake prefix path

View original Github issue

Metadata

Project
snapcraft
Number
#5589
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5589 (commit d30f563a7) fixed the GNOME extension's CMAKE_PREFIX_PATH to point at $CRAFT_STAGE/usr and the SDK snap's usr dir, a follow-up to #5272; released in snapcraft 8.10.1.

Resolution: closed resolved

Reason: The PR was merged to main as commit d30f563a7, changing snapcraft/extensions/gnome.py so CMAKE_PREFIX_PATH prepends '$CRAFT_STAGE/usr' and '/snap/{sdk_snap}/current/usr'. The changelog confirms it: snapcraft 8.10.1 lists '#5272 The CMAKE_PREFIX_PATH environment variable for the GNOME and KDE extensions now point to the usr sub-directory inside the SDK snap and the stage directories.' The two failing spread-test jobs were unrelated store/environment failures and did not block the merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- This is a follow-up fix to #5272, where the cmake prefix path needs to be look in `usr`. This is fixed for KDE in #5585.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5589 (commit d30f563a7) fixed the GNOME extension's CMAKE_PREFIX_PATH to point at $CRAFT_STAGE/usr and the SDK snap's usr dir, a follow-up to #5272; released in snapcraft 8.10.1.
stealth/space-bunny-alpha — closed resolved Merged in #5589 as d30f563a7, fixing GNOME CMake discovery by adding the staged usr directory to CMAKE_PREFIX_PATH and completing the follow-up to #5272.
stealth/space-bunny-alpha — closed resolved Merged as #5589 (commit d30f563a7), updating GNOME's CMake prefix path to look under usr. Followed #5272 and accompanied the KDE fix in #5585.
qwen/qwen3.6-35b-a3b — — Merged fix updating the cmake prefix path to usr for GNOME. Follows up on #5272 and complements the KDE fix in #5585. Approved by three reviewers, passed CI checks, and integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix updating the cmake prefix path for GNOME to search in usr. This follow-up to #5272 aligns with the KDE fix in #5585, resolving build configuration inconsistencies.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#5272 (confidence 99%)

    The parent bug report this PR fixes; CMAKE_PREFIX_PATH was not set correctly with the gnome extension, and its summary confirms the reporter validated the fix from #5589.

  • Related To: snapcraft#5585 (confidence 98%)

    Sibling PR (commit e2daf4cbe) applying the same usr-subdirectory fix to kde-neon; explicitly cited in #5589's description and shipped together in 8.10.1.

  • Caused By: snapcraft#5461 (confidence 90%)

    Commit a3f33196f 'feat(gnome): add cmake prefix path' introduced the incorrect paths and sits directly above d30f563a7 in the gnome.py history; 8.9 release notes flagged #5272 as a known issue.

Related issues

Issue Project State Summary Similarity
#5461 feat(gnome): add cmake prefix path snapcraft merged Merged PR #5461 (commit a3f33196f) added CMAKE_PREFIX_PATH=$CRAFT_STAGE/usr to the GNOME extension build environment, fixing #5272. Follow-up #5589 (d30f563a7) added the SDK usr prefix; shipped in snapcraft 8.10.1.
93%
#5272 CMAKE_PREFIX_PATH is not set with gnome extenstion snapcraft closed GNOME/KDE extension CMAKE_PREFIX_PATH handling was corrected by merged PR #5589 (d30f563a7), adding stage and SDK usr prefixes; released in Snapcraft 8.10.1.
80%
#2098893 CMAKE_PREFIX_PATH is not set with gnome extenstion snapcraft (launchpad) closed Fixed by merged PR snapcraft#5589 (d30f563a7), correcting the GNOME extension’s CMAKE_PREFIX_PATH to include /usr; initial support was added in #5461 (a3f33196f).
77%
#5310 fix: Fix cmake prefix path and remove invalid cmake root path. snapcraft merged Merged as 9cb3f5155, fixing KDE Neon CMake prefix handling and removing an invalid CMake root path in Snapcraft 8.8; fixes #5302.
76%
#5515 feat(gnome): Add SNAPCRAFT_GNOME_SDK env snapcraft merged Merged PR #5515 (commit 0e880534e) adds a SNAPCRAFT_GNOME_SDK build-environment variable to the GNOME extension, exposing the SDK snap path (/snap/gnome-XX-XXXX-sdk/current/); documented in gnome extension docs and the 8.13 release notes.
76%
#5514 extensions/gnome: Add sdk include directories to C_INCLUDE_PATH snapcraft open Adds GNOME SDK header paths to C_INCLUDE_PATH and updates tests/docs. Most CI passes, but maintainers say it could break stable core24 builds and should wait for Snapcraft 9/core26.
70%