← Back to issue list

feat(gnome): Add SNAPCRAFT_GNOME_SDK env

View original Github issue

Metadata

Project
snapcraft
Number
#5515
Type
pull request
State
merged
Author
3v1n0
Labels
PR: Run Manual Spread
Created
Updated
Closed

Current evaluation

Merged PR #5515 (commit 0e880534e) adds a SNAPCRAFT_GNOME_SDK build-environment variable to the GNOME extension, exposing the SDK snap path (/snap/gnome-XX-XXXX-sdk/current/); documented in gnome extension docs and the 8.13 release notes.

Resolution: closed resolved

Reason: The PR was merged into main as commit 0e880534e 'feat(gnome): Add SNAPCRAFT_GNOME_SDK env (#5515)'. snapcraft/extensions/gnome.py now sets SNAPCRAFT_GNOME_SDK in get_part_snippet, with unit tests (tests/unit/extensions/test_gnome.py) and docs updated.

Evaluated by: mr-cal-bot

No scores available.

Issue body

While building package using the gnome extension it's often required to define new environment paths that are based on the gnome sdk snap path. Instead of having to make such path a static string, expose it as an env variable to make it easier to set new variables and to simplify updates on core changes - [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5515 (commit 0e880534e) adds a SNAPCRAFT_GNOME_SDK build-environment variable to the GNOME extension, exposing the SDK snap path (/snap/gnome-XX-XXXX-sdk/current/); documented in gnome extension docs and the 8.13 release notes.
stealth/space-bunny-alpha — closed resolved Merged PR #5515 (commit 0e880534e) adds a SNAPCRAFT_GNOME_SDK build env var in snapcraft/extensions/gnome.py set to /snap/<gnome-sdk>/current/, so GNOME-extension builds avoid hardcoding the SDK path.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#5515 (commit 0e880534e), adding SNAPCRAFT_GNOME_SDK to the GNOME extension so SDK paths need not be hardcoded.
qwen/qwen3.6-35b-a3b — — Merged addition of the SNAPCRAFT_GNOME_SDK environment variable to expose the GNOME SDK snap path, eliminating hardcoded values. Approved by three reviewers and passing CI, the change modifies three files with six lines added.
qwen3.6-35b-a3b-mtp-q6 — — Merged addition of the SNAPCRAFT_GNOME_SDK environment variable. Exposes the GNOME SDK path to prevent hardcoding in extensions and applications, streamlining path management and future updates.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5461 feat(gnome): add cmake prefix path snapcraft merged Merged PR #5461 (commit a3f33196f) added CMAKE_PREFIX_PATH=$CRAFT_STAGE/usr to the GNOME extension build environment, fixing #5272. Follow-up #5589 (d30f563a7) added the SDK usr prefix; shipped in snapcraft 8.10.1.
78%
#5589 fix(gnome): update cmake prefix path snapcraft merged Merged PR #5589 (commit d30f563a7) fixed the GNOME extension's CMAKE_PREFIX_PATH to point at $CRAFT_STAGE/usr and the SDK snap's usr dir, a follow-up to #5272; released in snapcraft 8.10.1.
76%
#1805226 gnome extension snapcraft (launchpad) closed GNOME extension shipped in snapcraft 19.04: linked PR snapcore/snapcraft#2398 was closed unmerged and the reworked implementation merged in snapcraft#2655 (commit b0c4319e5, 'extensions: new gnome extension').
72%
#2655 Gnome extension snapcraft merged Merged PR #2655 introduced Snapcraft’s initial GNOME extension, including platform wiring and tests. The change landed as commit b0c4319e5.
71%