← Back to issue list

Make the IsDirty unit test case pass in architectures other than amd64.

View original Github issue

Metadata

Project
snapcraft
Number
#553
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 393c4e201, dropping the hardcoded architecture from the pluginhandler test setup so the IsDirty test passes on non-amd64. Resolves LP #1589752; part of a series with #552/#554.

Resolution: closed resolved

Reason: The PR was merged into main as commit 393c4e201 ("Make the IsDirty unit test case pass in architectures other than amd64. (#553)"), a +1/-2 line change to the pluginhandler test fixture that removes the architecture-specific setup. Maintainer comments only requested a retest, and the change addresses Launchpad bug #1589752.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Remove the architecture in the pluginhandler test case setup. LP: #1589752

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 393c4e201, dropping the hardcoded architecture from the pluginhandler test setup so the IsDirty test passes on non-amd64. Resolves LP #1589752; part of a series with #552/#554.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#553 (commit 393c4e201), removing architecture-specific pluginhandler test setup so IsDirty passes on non-amd64; resolves LP #1589752.
qwen/qwen3.6-35b-a3b — — Merged a change removing architecture-specific setup in the pluginhandler test case, fixing the IsDirty unit test on non-amd64 architectures. Resolves LP: #1589752 and depends on #552.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for the IsDirty unit test failing on non-amd64 architectures by removing architecture-specific setup from the pluginhandler test case, resolving launchpad bug #1589752.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#552 (confidence 88%)

    Sibling PR from the same arch-dependent test failure cleanup, merged as commit 65c1fac for the lxd cleanbuild test (LP #1589747); the author cross-referenced it on this PR.

  • Related To: canonical/snapcraft#554 (confidence 70%)

    Continued the same series of non-amd64 test fixes for snap tests (commit baed96749, LP #1589779).

  • Related To: snapcraft#945 (confidence 45%)

    Later, broader effort (commit 073332b9b) making the unit test suite architecture-agnostic on armhf (LP #1643029).

Related issues

Issue Project State Summary Similarity
#552 Make the lxd unit test pass in architectures other than amd64. snapcraft merged Merged PR #552 via commit 65c1fac, making the LXD unit test pass on architectures other than amd64 and addressing LP #1589747.
72%
#1589752 unit tests in IsDirtyTestCase fail when executed in a platform that's not amd64 snapcraft (launchpad) closed Fixed by upstream PR ubuntu-core/snapcraft#553 (commit 393c4e201), which made IsDirtyTestCase architecture-agnostic; released in snapcraft 2.11 to xenial -updates, SRU verified.
71%