Fix unittests in armhf
Metadata
Current evaluation
Merged PR #945 as commit 073332b9b, making Snapcraft unit tests architecture-agnostic so they pass on armhf.
Resolution: closed resolved
Reason: PR #945 was merged as commit 073332b9b, replacing architecture-dependent unit-test behavior with architecture-agnostic checks for armhf.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1643029
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #945 as commit 073332b9b, making Snapcraft unit tests architecture-agnostic so they pass on armhf. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #945 as commit 073332b9b, fixing Snapcraft unit tests on armhf while keeping coverage unchanged at 97.06%. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #945 as commit 073332b9b, fixing Snapcraft unit tests on armhf with a three-file +33/-16 update; coverage remained at 97.06%. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #945 as commit 073332b9b, fixing armhf unit tests for LP #1643029 while leaving code coverage unchanged. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for armhf unit tests. Updated 3 files with 33 additions and 16 deletions. Code coverage remained stable at 97.06% post-merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master to fix failing armhf unit tests. Coverage remained at 97.06% and launchpad bug #1643029 was resolved. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#917
(confidence 99%)
Earlier same-titled PR closed unmerged in favor of #945 to separate armhf unit-test fixes from other test work.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #917 Fix unittests in armhf | snapcraft | closed | armhf unit-test fixes PR closed unmerged by come-maiz in favor of #945, which split integration and snaps tests onto separate branches; #945 was later merged as commit 073332b9b. | |
| #990 tests: fix snaps tests in armhf | snapcraft | merged | Merged PR #990 as commit f467e55bc, correcting armhf failures in snap tests across 11 files and closing Launchpad bug #1650458. | |
| #1643029 unittests are not passing in armhf | snapcraft (launchpad) | closed | Architecture-hardcoded unit tests (pluginhandler IsDirty and commands push) were made arch-agnostic by canonical/snapcraft#945, commit 073332b9b "tests: fix unittests for armhf", closing the armhf autopkgtest failures. | |
| #1649899 integration tests fail in armhf | snapcraft (launchpad) | closed | Armhf integration tests were fixed and re-enabled by merged PR snapcore/snapcraft#971 (commit a725e69da). | |
| #971 tests: fix integration tests in armhf | snapcraft | merged | Merged PR #971 as commit a725e69da, fixing armhf integration-test setup with architecture-specific test configuration. | |
| #1595 tests: fix the skip of snapd integration tests in armhf | snapcraft | merged | Merged #1595 (8db14753d), fixing armhf snapd integration-test skips by checking self.deb_arch only after the parent setUp initialized it. | |
| #1655203 rust test with revision is skipped in armhf | snapcraft (launchpad) | closed | Fixed by PR snapcraft#1040, which changed the Rust integration-test revision to one supporting armhf. | |
| #145 fix: fix tests on arm64 | craft-archives | merged | Merged as commit 8459563, fixing arm64 test expectations after prerequisite #143 and resolving #144. | |
| #5132 push of locally built snap fails on arm64 device | snapcraft | closed | Fixed in Snapcraft 8.6 by merged PR #5136 (commit 2e7f5c3b), which migrated Snapcraft to core24 and updated bundled unsquashfs to 4.6.1; overlapping PR #5147 was closed. | |
| #1430 tests: enable the snaps installation in armhf | snapcraft | closed | PR #1430 was closed unmerged as stale WIP; its attempt to enable snap-installation tests on armhf was abandoned after the change stopped working. |