← Back to issue list

docs: update CONTRIBUTING.md

View original Github issue

Metadata

Project
snapcraft
Number
#5578
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged as 889bd6c79: refreshed CONTRIBUTING.md, removed HACKING.md, and reverted an unnecessary docs/conf.py change.

Resolution: closed resolved

Reason: PR #5578 received two approvals and merged with all reported CI checks passing. Commit 889bd6c79 records the completed documentation cleanup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `make test`? --- SNAPCRAFT-1166 * Update CONTRIBUTING.md * Remove HACKING.md * Revert redundant change to `exclude_patterns` in `conf.py` [Updated CONTRIBUTING.md](https://github.com/canonical/snapcraft/blob/work/update-contributing-guide/CONTRIBUTING.md)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as 889bd6c79: refreshed CONTRIBUTING.md, removed HACKING.md, and reverted an unnecessary docs/conf.py change.
stealth/space-bunny-alpha — closed resolved Merged in #5578 as 889bd6c79, refreshing CONTRIBUTING.md, removing HACKING.md, and reverting an unnecessary docs/conf.py change.
stealth/space-bunny-alpha — closed resolved Merged as 889bd6c79 (#5578): refreshed CONTRIBUTING.md, removed HACKING.md, and reverted an unnecessary conf.py change. Approved by two reviewers with all CI checks passing.
qwen/qwen3.6-35b-a3b — — Merged after approvals and passing CI. Updated CONTRIBUTING.md, removed HACKING.md, and reverted a redundant conf.py change. A reviewer noted a remaining README reference to HACKING.md requiring separate handling.
qwen3.6-35b-a3b-mtp-q6 — — Merged documentation update revising CONTRIBUTING.md, removing HACKING.md, and reverting a redundant conf.py change. A reviewer flagged a lingering README reference to the deleted file, but the changes were accepted and merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#215 docs: add CONTRIBUTING.md imagecraft merged Merged PR #215 in commit b0aa9f2, replacing HACKING.md with a 312-line CONTRIBUTING.md aligned to the project's contribution model.
81%
#791 docs: update CONTRIBUTING.md craft-application merged Docs-only PR #791 merged as commit 60bc3fae, rewriting CONTRIBUTING.md (+278/-319, 3 files) and deleting HACKING.md. Approved by 2 reviewers; only the OSV-scanner check failed.
80%
#5628 docs: update CONTRIBUTING.md snapcraft merged CONTRIBUTING.md was overhauled and merged in PR #5628 as commit e76eb27c6; commit 52e61041 corrected an accidental revert before merge.
80%
#368 docs: update CONTRIBUTING.md craft-cli merged Merged PR #368 (commit e75f8ef) updated CONTRIBUTING.md to align with the project template, +107/-55 lines in one file; all CI checks passed.
78%
#299 docs: update `CONTRIBUTING.md` craft-store merged Merged a documentation-only CONTRIBUTING.md update (+107/-52) as commit cabdfe3 after three approvals; tests, lint, and documentation checks passed despite two failing OSV-scanner jobs.
76%
#2404 docs: update `CONTRIBUTING.md` charmcraft merged Merged docs PR #2404 as commit 1c0f9884, applying a small +5/-5 edit to CONTRIBUTING.md carrying over review feedback from other Canonical repos; 3 approvals, all CI green.
76%
#370 docs: update `CONTRIBUTING.md` craft-cli merged Merged PR #370 (commit b7a0dbb), aligning CONTRIBUTING.md with the project template and incorporating review wording changes.
75%
#2382 docs: update `CONTRIBUTING.md` charmcraft merged Docs-only PR by maintainer jahn-junior merged as commit 08bdaed6 (+103/-60), rewriting CONTRIBUTING.md; follow-up fixes landed in #2392 (make setup system packages) and #2404.
75%
#925 docs: add `CONTRIBUTING.md` rockcraft merged Merged as 3d63a806, replacing CONTRIBUTING.rst with updated CONTRIBUTING.md contributor guidelines.
75%
#1134 docs: add contributing.md craft-parts merged Merged #1134 in commit 71861d71, updating contribution guidelines and moving them to the standard CONTRIBUTING.md filename.
74%