← Back to issue list

docs: update CONTRIBUTING.md

View original Github issue

Metadata

Project
craft-application
Number
#791
Type
pull request
State
merged
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Docs-only PR #791 merged as commit 60bc3fae, rewriting CONTRIBUTING.md (+278/-319, 3 files) and deleting HACKING.md. Approved by 2 reviewers; only the OSV-scanner check failed.

Resolution: closed resolved

Reason: The PR itself was merged into the main branch as commit 60bc3fae ("docs: update CONTRIBUTING.md (#791)"), which also removed HACKING.md. All substantive CI checks passed; the lone failing job was the unrelated Security scan / OSV-scanner.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the guidelines for contributing? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- * Update CONTRIBUTING.md * Remove HACKING.md [Updated CONTRIBUTING.md](https://github.com/canonical/craft-application/blob/work/update-contribution-guide/CRAFT-4607/%20%20CONTRIBUTING.md)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Docs-only PR #791 merged as commit 60bc3fae, rewriting CONTRIBUTING.md (+278/-319, 3 files) and deleting HACKING.md. Approved by 2 reviewers; only the OSV-scanner check failed.
stealth/space-bunny-alpha — closed resolved Merged as #791 (commit 60bc3fae), updating CONTRIBUTING.md and removing HACKING.md; review was approved and OSV-scanner was the only listed failing check.
qwen/qwen3.6-35b-a3b — — Merged after reviewer approval and passing CI checks. Updated CONTRIBUTING.md and removed HACKING.md.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#826 (confidence 70%)

    Follow-up docs PR #826 (commit 23a2d682) updated CONTRIBUTING.md again to align with Canonical's contribution template; a later commit 4f1434fc aligned it further.

Related issues

Issue Project State Summary Similarity
#299 docs: update `CONTRIBUTING.md` craft-store merged Merged a documentation-only CONTRIBUTING.md update (+107/-52) as commit cabdfe3 after three approvals; tests, lint, and documentation checks passed despite two failing OSV-scanner jobs.
85%
#368 docs: update CONTRIBUTING.md craft-cli merged Merged PR #368 (commit e75f8ef) updated CONTRIBUTING.md to align with the project template, +107/-55 lines in one file; all CI checks passed.
81%
#5578 docs: update CONTRIBUTING.md snapcraft merged Merged as 889bd6c79: refreshed CONTRIBUTING.md, removed HACKING.md, and reverted an unnecessary docs/conf.py change.
80%
#215 docs: add CONTRIBUTING.md imagecraft merged Merged PR #215 in commit b0aa9f2, replacing HACKING.md with a 312-line CONTRIBUTING.md aligned to the project's contribution model.
80%
#5628 docs: update CONTRIBUTING.md snapcraft merged CONTRIBUTING.md was overhauled and merged in PR #5628 as commit e76eb27c6; commit 52e61041 corrected an accidental revert before merge.
78%
#2404 docs: update `CONTRIBUTING.md` charmcraft merged Merged docs PR #2404 as commit 1c0f9884, applying a small +5/-5 edit to CONTRIBUTING.md carrying over review feedback from other Canonical repos; 3 approvals, all CI green.
78%
#370 docs: update `CONTRIBUTING.md` craft-cli merged Merged PR #370 (commit b7a0dbb), aligning CONTRIBUTING.md with the project template and incorporating review wording changes.
78%
#2353 docs: update `CONTRIBUTING.md` charmcraft merged Docs-only PR #2353 merged as commit 62abb2f4, replacing CONTRIBUTING.md with shared Starcraft guidance (+257/-58 across 2 files) and dropping a misplaced README link; approved by 2 reviewers.
78%
#5637 docs: fix CONTRIBUTING.md typos snapcraft merged Docs-only PR merged as commit 4ad38c556, correcting typos and internal links in CONTRIBUTING.md (+3/-3, one file); approved by two reviewers.
77%
#1052 docs: Update README.md contributing link rockcraft merged Merged PR #1052 (commit 509abf1a) fixed the broken contributing link in README.md, pointing it to CONTRIBUTING.md instead of the stale URL. Docs-only, +1/-1 lines; approved by 3 reviewers.
77%