← Back to issue list

fix: terminate services and fix typo in test template

View original Github issue

Metadata

Project
snapcraft
Number
#5608
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged #5608 in commit 71fc80ffc, fixing #5601 by terminating services during snap removal and correcting the unattended-upgrades command typo.

Resolution: closed resolved

Reason: PR #5608 was merged as commit 71fc80ffc. It added service termination during snap removal, corrected the test-template command typo, and resolved issue #5601.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #5601 - [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #5608 in commit 71fc80ffc, fixing #5601 by terminating services during snap removal and correcting the unattended-upgrades command typo.
stealth/space-bunny-alpha — closed resolved Merged #5608 (71fc80ffc), adding --terminate to snap removal and correcting the unattended-upgrades disable command, resolving #5601.
qwen/qwen3.6-35b-a3b — — Merged fix for #5601 terminating services and correcting a test template typo. Unrelated CI failures occurred due to dirmngr issues, but the target test passed, received two approvals, and was successfully merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for issue #5601 terminating services and correcting a test template typo. Unrelated dirmngr failures in repository tests were noted but did not block the merge. Maintainer verified the init-test passed.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5601 (confidence 100%)

    The issue reporting the test-template errors was fixed by merged PR #5608.

Related issues

Issue Project State Summary Similarity
#5601 Fix errors in test template snapcraft closed Fixed in canonical/snapcraft#5608 (commit 71fc80ffc): test templates now terminate services during snap removal and correctly disable unattended upgrades.
84%
#417 test: fix typos in extension and terminate services fetch-service merged Merged PR #417 corrected typos in the spread extension and terminate-services test code, landing as commit 8363f15.
71%