← Back to issue list

Fix errors in test template

View original Github issue

Metadata

Project
snapcraft
Number
#5601
Type
issue
State
closed
Author
cmatsuoka
Labels
Status: Triaged
Created
Updated
Closed

Current evaluation

Fixed in canonical/snapcraft#5608 (commit 71fc80ffc): test templates now terminate services during snap removal and correctly disable unattended upgrades.

Resolution: closed resolved

Reason: Commit 71fc80ffc, delivered by PR #5608, added --terminate to snap removal and corrected the unattended-upgrades command typo.

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description - Add `--terminate` when removing the snap in the general suite restore scriptlet. - Fix typo in command to disable unattended upgrades in .extension. ### To Reproduce Inspect the affected scripts and read the command lines. ### Environment These files are templates that will be copied to the user's environment when `snapcraft init --profile=test` is executed. ### snapcraft.yaml ```yaml N/A ``` ### Relevant log output ```shell N/A ``` ### Additional context _No response_

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed in canonical/snapcraft#5608 (commit 71fc80ffc): test templates now terminate services during snap removal and correctly disable unattended upgrades.
stealth/space-bunny-alpha — closed resolved Both errors in the `snapcraft init --profile=test` templates were fixed by merged PR #5608 (commit 71fc80ffc): snap removal now passes --terminate and the unattended-upgrades command typo was corrected.
stealth/space-bunny-alpha — closed resolved Fixed in canonical/snapcraft#5608 (commit 71fc80ffc) by adding --terminate to test-profile snap removal and correcting the unattended-upgrades typo.
stealth/space-bunny-alpha — closed resolved Test template errors were fixed in #5608 (commit 71fc80ffc): snap removal gained --terminate, and the unattended-upgrades command typo was corrected.
qwen/qwen3.6-35b-a3b — — Resolved. Test template errors were fixed by adding the --terminate flag to the snap removal scriptlet and correcting the unattended upgrades disable command.
qwen/qwen3.6-35b-a3b — — Closed as fixed. Applied corrections to the test template scripts, adding the --terminate flag to the restore scriptlet and fixing a typo in the unattended upgrades command.
qwen/qwen3.6-35b-a3b — — Fixed test template errors by adding the --terminate flag to the snap removal scriptlet and correcting a typo in the unattended upgrades command. The issue was closed after the maintainer applied the changes.
qwen3.6-35b-a3b-mtp-q6 — — Fixed errors in test templates by adding the --terminate flag to the snap removal scriptlet and correcting a typo in the unattended upgrades disable command. Issue closed.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#5608 (confidence 100%)

    The PR implemented both test-template corrections in commit 71fc80ffc.

Related issues

Issue Project State Summary Similarity
#5608 fix: terminate services and fix typo in test template snapcraft merged Merged #5608 in commit 71fc80ffc, fixing #5601 by terminating services during snap removal and correcting the unattended-upgrades command typo.
84%
#85 test: cleanup test now that we have a new enough snapcraft snapcraft-rocks merged Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666.
73%