feat(project): add pydantic validator for common_id field
Metadata
Current evaluation
Closed without merging due to failing CI checks and unresolved review comments. Added a pydantic validator for the common_id field but did not resolve integration test failures or linting issues.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
fixes #5624
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to failing CI checks and unresolved review comments. Added a pydantic validator for the common_id field but did not resolve integration test failures or linting issues. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve issue #5624. Adds a Pydantic validator for the common_id field to enforce data validation. All lint and test checks passed, and the contributor confirmed completion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged the addition of a pydantic validator for the common_id field, resolving issue #5624. The contributor completed requested changes and the pull request was closed after review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5974 feat(project): add pydantic validator for common_id field | snapcraft | open | Adds a pydantic validator for the app common_id field to catch invalid values early, fixing #5624. Open 221 days with no author activity, 3 unresolved review comments, and failing integration/OSV-scanner CI; the validator is absent from current main. | |
| #5624 Add a pydantic validator for common-id | snapcraft | open | Enhancement to add a pydantic validator for the common-id field (per appstream spec) to catch invalid values early. Triaged; PR #5974 targets it but is stalled with failing CI, and the validator is absent from main. |