feat(project): add pydantic validator for common_id field
Metadata
Current evaluation
Closed unmerged with failing CI and five unresolved review comments; no validator change landed. Issue #5624 remains open, with later PR #5974 carrying the same work.
Resolution: closed stale
Reason: PR #5625 was abandoned without merging after multiple CI failures and with five unresolved review comments. Issue #5624 remains open, while successor PR #5974 is also unmerged.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
fixes #5624
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged with failing CI and five unresolved review comments; no validator change landed. Issue #5624 remains open, with later PR #5974 carrying the same work. | |
| stealth/space-bunny-alpha | — | closed stale | PR #5625 was closed unmerged with failing CI and five unresolved review comments. Issue #5624 remains open, while successor PR #5974 continues the work. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to failing CI checks and unresolved review comments. Added a pydantic validator for the common_id field but did not resolve integration test failures or linting issues. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve issue #5624. Adds a Pydantic validator for the common_id field to enforce data validation. All lint and test checks passed, and the contributor confirmed completion. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#5624
(confidence 100%)
The original issue remains open because the proposed fix was not merged.
-
Superseded By:
canonical/snapcraft#5974
(confidence 95%)
Later open PR carries the same common_id validator work.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5974 feat(project): add pydantic validator for common_id field | snapcraft | open | Adds a pydantic validator for App.common_id enforcing appstream desktop-ID format, with unit tests and docs. Successor to closed #5625 for issue #5624. Dormant 252 days, 3 unresolved review comments, 3 CI checks failing. |