← Back to issue list

feat(project): add pydantic validator for common_id field

View original Github issue

Metadata

Project
snapcraft
Number
#5974
Type
pull request
State
open
Author
soumyaDghosh
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a pydantic validator for App.common_id enforcing appstream desktop-ID format, with unit tests and docs. Successor to closed #5625 for issue #5624. Dormant 252 days, 3 unresolved review comments, 3 CI checks failing.

Suggested action: needs review

Reason: The change is coherent and still needed: App.common_id at snapcraft/models/project.py:478 has no validator at HEAD, and issue #5624 remains open and triaged with a volunteer contributor, so this is not superseded. However, review status is 'pending (0 reviewers)' with 3 unresolved review comments and no author activity for 252 days, plus integration-spread-tests (22.04/24.04) and Security scan / OSV-scanner failing. Author non-response means this is not cleanly 'ready', but inactivity alone does not justify closing and the validator is absent from HEAD, so a maintainer needs to triage the outstanding comments.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 6 Complexity: 22 Confidence: 68 Actionability: 25

Issue body

fixes https://github.com/canonical/snapcraft/issues/5624 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 30
Quick Win: 6
Complexity: 22
Confidence: 68
Actionability: 25
needs review Adds a pydantic validator for App.common_id enforcing appstream desktop-ID format, with unit tests and docs. Successor to closed #5625 for issue #5624. Dormant 252 days, 3 unresolved review comments, 3 CI checks failing.
stealth/space-bunny-alpha
Impact: 35
Quick Win: 4
Complexity: 25
Confidence: 62
Actionability: 15
close stale Adds a pydantic validator for App.common_id to enforce AppStream spec rules. Open 253 days, no reviews, 3 unresolved comments, two spread-test jobs and OSV-scanner failing; predecessor PR #5625 closed unmerged.
stealth/space-bunny-alpha
Impact: 24
Quick Win: 1
Complexity: 30
Confidence: 78
Actionability: 8
close stale Adds an AppStream reverse-DNS pydantic validator for the App common-id field (+38/-12, 5 files), successor to closed-unmerged #5625. Stalled 252 days with 3 unresolved review comments, no reviewer, 3 failing spread/security CI checks.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 5
Complexity: 30
Confidence: 70
Actionability: 15
close stale Adds a pydantic validator for the common_id field to validate values per appstream spec. Open for 241 days with 3 unresolved review comments, failing CI checks, and no author activity for 240 days.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 20
Staleness: 75
Complexity: 20
Confidence: 75
close stale Adds a pydantic validator for the app common_id field to catch invalid values early, fixing #5624. Open 221 days with no author activity, 3 unresolved review comments, and failing integration/OSV-scanner CI; the validator is absent from current main.
qwen/qwen3.6-35b-a3b
Staleness: 55
Complexity: 25
Confidence: 70
needs review Adds a pydantic validator for the common_id field to address issue #5624. The PR has passed most CI checks but remains pending with zero reviewers and three unresolved comments after six months of inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 20
Confidence: 70
needs review Adds a pydantic validator for the common_id field to address issue #5624. Currently inactive for over 5 months with no maintainer comments or updates.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#5624 (confidence 95%)

    Explicitly stated in the PR body as 'fixes'; issue is open and triaged, so the requested work is still outstanding.

  • Related To: snapcraft#5625 (confidence 88%)

    Earlier attempt at the identical change, closed unmerged with failing CI and five unresolved review comments; this PR is its successor and likely carries the same unresolved feedback.

Related issues

Issue Project State Summary Similarity
#5624 Add a pydantic validator for common-id snapcraft open Enhancement to add a pydantic validator for App.common_id enforcing the AppStream desktop-app ID format, so bad IDs fail before a build environment starts. Still open at HEAD; two implementation PRs (#5625 closed unmerged, #5974 stalled) have failed so far.
84%
#5625 feat(project): add pydantic validator for common_id field snapcraft closed Closed unmerged with failing CI and five unresolved review comments; no validator change landed. Issue #5624 remains open, with later PR #5974 carrying the same work.
83%