← Back to issue list

feat(project): add pydantic validator for common_id field

View original Github issue

Metadata

Project
snapcraft
Number
#5974
Type
pull request
State
open
Author
soumyaDghosh
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds a pydantic validator for the app common_id field to catch invalid values early, fixing #5624. Open 221 days with no author activity, 3 unresolved review comments, and failing integration/OSV-scanner CI; the validator is absent from current main.

Suggested action: close stale

Reason: The author has not responded to 3 unresolved review comments in 221 days (far beyond the 3-month threshold for unaddressed maintainer feedback), and CI still fails on integration-spread-tests (ubuntu-22.04/24.04) and OSV-scanner. The common_id field in snapcraft/models/project.py still has no validator in main and issue #5624 remains open, so the work can be redone if maintainers still want it.

Impact: 25 Quick Win: 20.0 Staleness: 75 Complexity: 20 Confidence: 75

Issue body

fixes https://github.com/canonical/snapcraft/issues/5624 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 20.0
Staleness: 75
Complexity: 20
Confidence: 75
close stale Adds a pydantic validator for the app common_id field to catch invalid values early, fixing #5624. Open 221 days with no author activity, 3 unresolved review comments, and failing integration/OSV-scanner CI; the validator is absent from current main.
qwen/qwen3.6-35b-a3b
Staleness: 55
Complexity: 25
Confidence: 70
needs review Adds a pydantic validator for the common_id field to address issue #5624. The PR has passed most CI checks but remains pending with zero reviewers and three unresolved comments after six months of inactivity.
qwen3.6-35b-a3b-mtp-q6
Staleness: 85
Complexity: 20
Confidence: 70
needs review Adds a pydantic validator for the common_id field to address issue #5624. Currently inactive for over 5 months with no maintainer comments or updates.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 20
Confidence: 75
needs review Adds a Pydantic validator for the common_id field to enforce configuration constraints, fixing issue 5624. Open for 145 days with zero comments or labels, it is currently stale and awaiting maintainer review.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5624 (confidence 90%)

    PR body states 'fixes #5624' (Add a pydantic validator for common-id); that issue is still open and the validator is not present in current main.

Related issues

Issue Project State Summary Similarity
#5625 feat(project): add pydantic validator for common_id field snapcraft closed Closed without merging due to failing CI checks and unresolved review comments. Added a pydantic validator for the common_id field but did not resolve integration test failures or linting issues.
86%
#5624 Add a pydantic validator for common-id snapcraft open Enhancement to add a pydantic validator for the common-id field (per appstream spec) to catch invalid values early. Triaged; PR #5974 targets it but is stalled with failing CI, and the validator is absent from main.
82%